-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document web module #1041
Merged
Merged
Document web module #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
=======================================
Coverage 74.18% 74.19%
=======================================
Files 64 65 +1
Lines 15915 15916 +1
=======================================
+ Hits 11807 11809 +2
+ Misses 4108 4107 -1
☔ View full report in Codecov by Sentry. |
I finished documenting the web module, converted it in a library in order to add more tests and doc-tests, and also improved the |
marco-c
reviewed
May 22, 2023
marco-c
reviewed
May 22, 2023
The web module has been converted in a lib, but also maintaining the associated binary.
marco-c
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #383.
Unfortunately doc tests on binary cannot still be executed because of rust-lang/rust#50784 (comment), but we can create them the same waiting for the feature to be implemented
Otherwise we can transform this module in a lib, with a binary associated, in this way we can document all APIs and at the same time having an executable