Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS backend - More granular logging depending on GCS response codes #1180

Open
dcaba opened this issue Jun 2, 2022 · 0 comments
Open

GCS backend - More granular logging depending on GCS response codes #1180

dcaba opened this issue Jun 2, 2022 · 0 comments

Comments

@dcaba
Copy link

dcaba commented Jun 2, 2022

Right now, at least in the GCS backend implementation:

Err(e) => {

There are only two situations from an error management perspective:

  • We found a cached object in the bucket and we are getting the associated data, so great...
  • Everything else, that triggers a WARN in the logs/output, if enabled

Problem is that everything else...

  • We are generating WARN on 404 responses, which is very legit when we are building changes/new things, generating noise / even misunderstandings
  • Auth issues are also logged as WARN (but they effectively make the backend unusable), rather than ERROR, which are probably very relevant, and easy to miss depending on log level (and the rest of noise now we categorize as WARN)

Should we inspect the inner BadHttpStatusError and segregate things like this? Happy to submit an small PR about that, if that makes sense to others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant