Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rusoto now has a standalone credentials module #28

Closed
indiv0 opened this issue Nov 27, 2016 · 3 comments
Closed

Rusoto now has a standalone credentials module #28

indiv0 opened this issue Nov 27, 2016 · 3 comments

Comments

@indiv0
Copy link

indiv0 commented Nov 27, 2016

It looks like rusoto support was dropped in 657cb89 for various reasons. However, you retained the rusoto credentials code in the form of an extracted file (src/simples3/credential.rs).

It might interest you to know that rusoto now has a standalone credentials module, which is published and functions independently of the main rusoto module. If you are interested in using it in your project, I can look into porting the modifications you've made to your version of the module into ours.

@luser
Copy link
Contributor

luser commented Nov 27, 2016

Oh, that would be super useful! FWIW, I liked Rusoto, I was just hitting some hard-to-diagnose issues and my S3 needs were fairly simple. I've only made a few small changes to the credentials module, I'd be happy to submit them as PRs.

@indiv0
Copy link
Author

indiv0 commented Nov 28, 2016

That would be great, actually. As for rusoto itself, we're close to landing an important PR (rusoto/rusoto#321) which will bring S3 in line with the rest of the codebase (currently it's mostly hand-crafted, legacy code from before our major re-write). Once that's done, I can help you migrate back to it for S3 as it's going to be much less problematic.

@Xuanwo
Copy link
Collaborator

Xuanwo commented Feb 17, 2023

This issue has been resolved by #1404

@Xuanwo Xuanwo closed this as completed Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants