Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clippy-driver as rustc #539

Open
yaahc opened this issue Oct 10, 2019 · 2 comments
Open

Support clippy-driver as rustc #539

yaahc opened this issue Oct 10, 2019 · 2 comments

Comments

@yaahc
Copy link
Contributor

yaahc commented Oct 10, 2019

The Preface

There is some vague talk of maybe someday integrating clippy-driver into cargo build and cargo check rust-lang/cargo#7382, so I went and tried to test if we could just use clippy-driver as a drop in replacement for rustc under cargo build and sccache did not play nicely with it.

The Problem

sccache flat out errors out if clippy-driver is passed in the place of rustc

Screenshot from 2019-10-10 14-17-16

The Fix

@mystor suggested that someone fix it @

let rustc_vv = if filename.to_string_lossy().to_lowercase() == "rustc" {
to work with clippy-driver.

@luser
Copy link
Contributor

luser commented Oct 11, 2019

I don't have clippy-driver installed locally. If you run clippy-driver -vV what does it output? sccache needs some way to determine whether the compiler is rustc or a C/C++ compiler.

@yaahc
Copy link
Contributor Author

yaahc commented Oct 12, 2019

It's the same output as rustc. For more details and entertainment check out

rust-lang/libc#1544

--version mentions it is clippy, with --vV clippy pretends to be rustc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants