handle panics in the (local) server by failing the compilation rather than hanging #756
Comments
|
I'm not sure there's a straightforward way to do this given the extensive use of futures. If it was a single-threaded computation you could wrap the whole thing in |
glandium
added a commit
to glandium/sccache
that referenced
this issue
Nov 22, 2023
Currently, when the server panics, the client never gets a response, and the compilation gets stuck. The only indication of something going wrong is in the logs if they are enabled. With this change, the error is transmitted to the client, which then fails and prints it. For instance, one of the out-of-bound accesses fixed in mozilla#1980 now prints this on the client side before returning a non-zero exit code: sccache: encountered fatal error sccache: error: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1 sccache: caused by: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1 Fixes mozilla#756
glandium
added a commit
to glandium/sccache
that referenced
this issue
Nov 22, 2023
Currently, when the server panics, the client never gets a response, and the compilation gets stuck. The only indication of something going wrong is in the logs if they are enabled. With this change, the error is transmitted to the client, which then fails and prints it. For instance, one of the out-of-bound accesses fixed in mozilla#1980 now prints this on the client side before returning a non-zero exit code: sccache: encountered fatal error sccache: error: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1 sccache: caused by: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1 Fixes mozilla#756
glandium
added a commit
to glandium/sccache
that referenced
this issue
Nov 22, 2023
Currently, when the server panics, the client never gets a response, and the compilation gets stuck. The only indication of something going wrong is in the logs if they are enabled. With this change, the error is transmitted to the client, which then fails and prints it. For instance, one of the out-of-bound accesses fixed in mozilla#1980 now prints this on the client side before returning a non-zero exit code: sccache: encountered fatal error sccache: error: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1 sccache: caused by: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1 Fixes mozilla#756
glandium
added a commit
to glandium/sccache
that referenced
this issue
Nov 22, 2023
Currently, when the server panics, the client never gets a response, and the compilation gets stuck. The only indication of something going wrong is in the logs if they are enabled. With this change, the error is transmitted to the client, which then fails and prints it. For instance, one of the out-of-bound accesses fixed in mozilla#1980 now prints this on the client side before returning a non-zero exit code: sccache: encountered fatal error sccache: error: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1 sccache: caused by: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1 Fixes mozilla#756
pull bot
pushed a commit
to exoosh/sccache
that referenced
this issue
Nov 23, 2023
Currently, when the server panics, the client never gets a response, and the compilation gets stuck. The only indication of something going wrong is in the logs if they are enabled. With this change, the error is transmitted to the client, which then fails and prints it. For instance, one of the out-of-bound accesses fixed in mozilla#1980 now prints this on the client side before returning a non-zero exit code: sccache: encountered fatal error sccache: error: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1 sccache: caused by: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1 Fixes mozilla#756
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I only found #755 because I had a server running in a separate window. If I hadn't been running the server in a place I could see its output, I would just have seen
sccachehang. It would be better to somehow return an error that was visible to the user.The text was updated successfully, but these errors were encountered: