Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate gcs cache to opendal based #1474

Merged
merged 7 commits into from
Dec 13, 2022

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Dec 13, 2022

Signed-off-by: Xuanwo github@xuanwo.io

This PR will introduce the following user face changes:

  • Add fully Google ADC support
  • Add SCCACHE_GCS_SERVICE_ACCOUNT to allow the user to specify the service account to fetch tokens from VM metadata.
  • Deprecate SCCACHE_GCS_CREDENTIALS_URL and SCCACHE_GCS_OAUTH_URL; hence we will build the correct URL via the service account instead.

And, yes, remove a lot of code 🚀

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov-commenter
Copy link

Codecov Report

Base: 29.86% // Head: 29.98% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (3a4b60b) compared to base (416c96c).
Patch coverage: 37.83% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
+ Coverage   29.86%   29.98%   +0.12%     
==========================================
  Files          47       47              
  Lines       16974    16572     -402     
  Branches     8056     7827     -229     
==========================================
- Hits         5069     4969     -100     
+ Misses       6503     6349     -154     
+ Partials     5402     5254     -148     
Impacted Files Coverage Δ
src/util.rs 34.53% <ø> (-0.78%) ⬇️
tests/sccache_cargo.rs 32.55% <ø> (+0.91%) ⬆️
src/cache/gcs.rs 29.41% <25.00%> (+8.96%) ⬆️
src/config.rs 35.81% <26.31%> (-0.75%) ⬇️
src/cache/cache.rs 35.29% <100.00%> (-0.71%) ⬇️
src/cache/disk.rs 35.61% <0.00%> (-1.37%) ⬇️
src/server.rs 31.67% <0.00%> (-0.43%) ⬇️
src/lib.rs 8.47% <0.00%> (-0.38%) ⬇️
src/compiler/c.rs 38.53% <0.00%> (-0.23%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/Gcs.md Outdated Show resolved Hide resolved
docs/S3.md Show resolved Hide resolved
Signed-off-by: Xuanwo <github@xuanwo.io>
@sylvestre sylvestre merged commit d0e8236 into mozilla:main Dec 13, 2022
@Xuanwo Xuanwo deleted the migrate-gcs-to-opendal branch December 13, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants