Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle -Xclang args when invoking clang/clang++ on windows cmake #1500

Merged
merged 4 commits into from
Jan 8, 2023
Merged

fix: handle -Xclang args when invoking clang/clang++ on windows cmake #1500

merged 4 commits into from
Jan 8, 2023

Conversation

Danielmelody
Copy link
Contributor

Instead of clang-cl.

@Danielmelody Danielmelody changed the title fix: hanlde Xlang args when invoking clang/clang++ on windows cmake fix: hanlde -Xclang args when invoking clang/clang++ on windows cmake Dec 26, 2022
@Danielmelody Danielmelody force-pushed the main branch 2 times, most recently from 04e55cb to a53c685 Compare December 26, 2022 14:43
@Danielmelody Danielmelody changed the title fix: hanlde -Xclang args when invoking clang/clang++ on windows cmake fix: handle -Xclang args when invoking clang/clang++ on windows cmake Dec 26, 2022
@Danielmelody
Copy link
Contributor Author

This PR also pass the unsupported flag name to error log, so that we can know which flag failed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022 •
edited
Loading

Codecov Report

Base: 30.09% // Head: 30.09% // No change to project coverage 👍

Coverage data is based on head (dd418ab) compared to base (dd418ab).
Patch has no changes to coverable lines.

❗ Current head dd418ab differs from pull request most recent head e574490. Consider uploading reports for the commit e574490 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1500   +/-   ##
=======================================
  Coverage   30.09%   30.09%           
=======================================
  Files          47       47           
  Lines       16643    16643           
  Branches     7907     7907           
=======================================
  Hits         5008     5008           
  Misses       6315     6315           
  Partials     5320     5320

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

glandium
glandium reviewed Dec 26, 2022
View reviewed changes
src/compiler/clang.rs Outdated
@@ -184,6 +185,7 @@ counted_array!(pub static ARGS: [ArgInfo<gcc::ArgData>; _] = [
take_arg!("-fprofile-use", PathBuf, Concatenated('='), ClangProfileUse),
take_arg!("-fsanitize-blacklist", PathBuf, Concatenated('='), ExtraHashFile),
take_arg!("-gcc-toolchain", OsString, Separated, PassThrough),
flag!("-gcodeview", PreprocessorArgumentFlag),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-gcodeview is not a preprocessor flag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, should I add a PassThroughFlag here?

@sylvestre
Copy link
Collaborator

please run rustfmt on your changes

@sylvestre sylvestre merged commit 45d4783 into mozilla:main Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glandium glandium glandium left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Danielmelody @codecov-commenter @sylvestre @glandium