-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add integration test for redis #1510
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Hi, @sylvestre, I want to use action |
I will ask my colleagues at Mozilla but it might take a week or two |
Ok, maybe it's better to avoid using new actions here. Let's use github native service feature. |
if you could, would be great indeed :) |
Codecov ReportBase: 30.00% // Head: 29.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1510 +/- ##
==========================================
- Coverage 30.00% 29.93% -0.08%
==========================================
Files 47 47
Lines 16714 16714
Branches 7929 7942 +13
==========================================
- Hits 5015 5003 -12
- Misses 6375 6393 +18
+ Partials 5324 5318 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
cc @sylvestre, this PR is ready for review now! |
Fails with
|
Signed-off-by: Xuanwo <github@xuanwo.io>
Fixed |
it would be nice to do a second build to verify that |
This is terrific. I wonder if we should not replicate this for other services |
This PR will add integration tests for redis