Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add integration test for redis #1510

Merged
merged 11 commits into from
Dec 27, 2022
Merged

ci: Add integration test for redis #1510

merged 11 commits into from
Dec 27, 2022

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Dec 27, 2022

This PR will add integration tests for redis

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Dec 27, 2022

shogo82148/actions-setup-redis@v1 is not allowed to be used in mozilla/sccache. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, or matching the following: !/mozilla/**, !mozilla/**, ./**, 10up/wpcs-action@*, aws-actions/*, docker/*, pypa/gh-action-pypi-publish@v1.4.2, slackapi/slack-github-action@*, google-github-actions/*, erlef/setup-beam@v1, yesolutions/mirror-action@*, codecov/codecov-action@*, tj-actions/changed-files@*, tj-actions/glob@*, vmactions/freebsd-vm@v0, actions-rs/toolchain@v1, shivammathur/setup-php@*, EmbarkStudios/*.

Hi, @sylvestre, I want to use action shogo82148/actions-setup-redis@v1.

@sylvestre
Copy link
Collaborator

I will ask my colleagues at Mozilla but it might take a week or two

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Dec 27, 2022

I will ask my colleagues at Mozilla but it might take a week or two

Ok, maybe it's better to avoid using new actions here. Let's use github native service feature.

@sylvestre
Copy link
Collaborator

if you could, would be great indeed :)

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2022

Codecov Report

Base: 30.00% // Head: 29.93% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (db0e782) compared to base (ad274ef).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
- Coverage   30.00%   29.93%   -0.08%     
==========================================
  Files          47       47              
  Lines       16714    16714              
  Branches     7929     7942      +13     
==========================================
- Hits         5015     5003      -12     
- Misses       6375     6393      +18     
+ Partials     5324     5318       -6     
Impacted Files Coverage Δ
src/jobserver.rs 47.91% <0.00%> (-4.17%) ⬇️
src/mock_command.rs 51.31% <0.00%> (-0.75%) ⬇️
src/server.rs 31.36% <0.00%> (-0.64%) ⬇️
src/dist/cache.rs 20.67% <0.00%> (-0.38%) ⬇️
src/compiler/args.rs 61.55% <0.00%> (-0.18%) ⬇️
src/compiler/compiler.rs 35.73% <0.00%> (-0.15%) ⬇️
src/compiler/rust.rs 33.39% <0.00%> (-0.14%) ⬇️
src/lib.rs 9.20% <0.00%> (-0.06%) ⬇️
src/util.rs 33.44% <0.00%> (ø)
src/compiler/msvc.rs 43.42% <0.00%> (+0.13%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Dec 27, 2022

cc @sylvestre, this PR is ready for review now!

Signed-off-by: Xuanwo <github@xuanwo.io>
@sylvestre
Copy link
Collaborator

Fails with

Run /home/runner/.cargo/bin/sccache --show-stats | grep redis --passthru
grep: unrecognized option '--passthru'

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Dec 27, 2022

Fails with

Run /home/runner/.cargo/bin/sccache --show-stats | grep redis --passthru
grep: unrecognized option '--passthru'

Fixed

@sylvestre
Copy link
Collaborator

it would be nice to do a second build to verify that
Cache hits isn't at 0 ?

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@sylvestre
Copy link
Collaborator

This is terrific. I wonder if we should not replicate this for other services
wdyt?

@sylvestre sylvestre merged commit 6cf985d into mozilla:main Dec 27, 2022
@Xuanwo Xuanwo deleted the redis-ci branch December 27, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants