Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining freebsd-ci problems #1556

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Conversation

grembo
Copy link
Contributor

@grembo grembo commented Jan 12, 2023

Fixes #1536

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Base: 30.89% // Head: 30.84% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (4a38383) compared to base (f452e4b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1556      +/-   ##
==========================================
- Coverage   30.89%   30.84%   -0.05%     
==========================================
  Files          48       48              
  Lines       16598    16598              
  Branches     7906     7908       +2     
==========================================
- Hits         5128     5120       -8     
+ Misses       6106     6103       -3     
- Partials     5364     5375      +11     
Impacted Files Coverage Δ
src/jobserver.rs 47.91% <0.00%> (-6.25%) ⬇️
src/cache/disk.rs 35.61% <0.00%> (-1.37%) ⬇️
src/compiler/gcc.rs 54.69% <0.00%> (-0.73%) ⬇️
src/cache/cache.rs 39.92% <0.00%> (-0.39%) ⬇️
src/mock_command.rs 52.43% <0.00%> (-0.38%) ⬇️
src/util.rs 35.17% <0.00%> (-0.33%) ⬇️
src/server.rs 31.94% <0.00%> (-0.32%) ⬇️
src/lru_disk_cache/mod.rs 41.03% <0.00%> (-0.31%) ⬇️
src/compiler/c.rs 38.44% <0.00%> (-0.23%) ⬇️
src/compiler/args.rs 62.23% <0.00%> (-0.18%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -290,6 +292,7 @@ test_sccache_dist_02()

cleanup()
{
trap - EXIT INT HUP
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a comment here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sylvestre I'll clean it up a bit so it's clear how it works (please ignore the intermediate commit)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sylvestre Code should be more obvious now.

Let's wait for CI builds to finish.

@sylvestre sylvestre merged commit e55ed88 into mozilla:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

freebsd tests failed during Deinstall pot (potpool/pot)
3 participants