Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clippy warnings #1561

Merged
merged 1 commit into from
Jan 28, 2023
Merged

fix: clippy warnings #1561

merged 1 commit into from
Jan 28, 2023

Conversation

Danielmelody
Copy link
Contributor

An automatically fix by running cargo clippy --fix. Not sure whether worth doing it seems no one running it before.

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Base: 31.05% // Head: 31.01% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (a4d4619) compared to base (4655373).
Patch coverage: 19.64% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1561      +/-   ##
==========================================
- Coverage   31.05%   31.01%   -0.05%     
==========================================
  Files          48       48              
  Lines       16568    16574       +6     
  Branches     7919     7939      +20     
==========================================
- Hits         5146     5140       -6     
- Misses       6067     6068       +1     
- Partials     5355     5366      +11     
Impacted Files Coverage Δ
src/cmdline.rs 24.03% <0.00%> (-0.38%) ⬇️
src/commands.rs 20.24% <0.00%> (ø)
src/compiler/diab.rs 47.86% <0.00%> (ø)
src/compiler/gcc.rs 56.03% <0.00%> (+0.92%) ⬆️
src/compiler/msvc.rs 43.40% <0.00%> (+0.05%) ⬆️
src/compiler/tasking_vx.rs 43.68% <0.00%> (ø)
src/dist/client_auth.rs 0.00% <0.00%> (ø)
src/dist/http.rs 0.00% <0.00%> (ø)
src/test/utils.rs 38.38% <0.00%> (-3.04%) ⬇️
tests/oauth.rs 0.64% <0.00%> (ø)
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre
Copy link
Collaborator

Cool
Could you please fix the rustfmt warning?

And could you please enable this warning in the ci? :)

Copy link
Collaborator

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reducing the visual load by operator removal is always a plus! Thank you!

@sylvestre
Copy link
Collaborator

@Danielmelody ping ?

@sylvestre sylvestre merged commit 4e4243e into mozilla:main Jan 28, 2023
@Danielmelody
Copy link
Contributor Author

Sorry for the late response, apparently I miss a comment from @sylvestre . But I will try to make other contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants