Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a profile section #1562

Merged
merged 1 commit into from
Jan 16, 2023
Merged

add a profile section #1562

merged 1 commit into from
Jan 16, 2023

Conversation

sylvestre
Copy link
Collaborator

@sylvestre sylvestre commented Jan 15, 2023

To make sure the binaries we publish are the best

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2023

Codecov Report

Base: 31.05% // Head: 30.97% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (2e44149) compared to base (4655373).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
- Coverage   31.05%   30.97%   -0.09%     
==========================================
  Files          48       48              
  Lines       16568    16568              
  Branches     7919     7935      +16     
==========================================
- Hits         5146     5132      -14     
- Misses       6067     6079      +12     
- Partials     5355     5357       +2     
Impacted Files Coverage Δ
src/util.rs 35.17% <0.00%> (-1.31%) ⬇️
src/test/utils.rs 40.40% <0.00%> (-1.02%) ⬇️
src/cache/cache.rs 39.46% <0.00%> (-0.77%) ⬇️
src/compiler/args.rs 61.70% <0.00%> (-0.54%) ⬇️
src/compiler/rust.rs 33.55% <0.00%> (-0.47%) ⬇️
src/compiler/c.rs 38.67% <0.00%> (-0.46%) ⬇️
src/lru_disk_cache/mod.rs 41.03% <0.00%> (-0.31%) ⬇️
src/compiler/compiler.rs 36.16% <0.00%> (-0.29%) ⬇️
src/config.rs 35.75% <0.00%> (-0.18%) ⬇️
src/lib.rs 10.82% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre sylvestre merged commit 53de1a0 into mozilla:main Jan 16, 2023
@sylvestre sylvestre deleted the profile.release branch January 16, 2023 07:50
codegen-units = 1
lto = true
strip = true
panic = "abort"
Copy link
Collaborator

@drahnr drahnr Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why we're not keeping backtraces? The performance overhead exists, but compared to cache fetches and launching other binaries, it should be rather negligible (gut feeling)?
For bug reports this provides usually viable info, iff something crashes (and we manage to collect the info).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants