-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Print sccache version for Server stats #1580
Conversation
3705606
to
da472ba
Compare
Codecov ReportBase: 30.93% // Head: 30.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
+ Coverage 30.93% 30.95% +0.02%
==========================================
Files 48 48
Lines 16625 16633 +8
Branches 7976 7982 +6
==========================================
+ Hits 5143 5149 +6
- Misses 6066 6070 +4
+ Partials 5416 5414 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
please add a test to make sure we don't regress in the future. Line 105 in 9c3f980
|
Agree. Nevertheless, I also have found this test, which could fit better & restricted to this? Add an extra assert or create a new one (perhaps too much for now & just a new static field) Line 150 in 8b11e89
Maybe I'm overthinking it too much... |
Sure, as you wish :) |
please run rustfmt on your change |
18794ed
to
c377e28
Compare
Sorry for the latency, i wanted to verify that json file also contained it :) (and it does) |
Hi.
Coming from this discussion started by @Xuanwo , it's has been considered a good idea to include the version info when running the sccache --show-stats command.
I have included a basic solution, directly included & calling the env! macro to get the CARGO_PKG_VERSION.
One of the pending confirmations should be the display info of this new version field, as it has been mentioned that it should be explicit regarding it's the client version.
It's not a big thing, but hope to help a bit with this cool project besides my ongoing learning of Rust.
Sorry in advance for any mistake.
Thanks.