Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Print sccache version for Server stats #1580

Merged
merged 3 commits into from
Feb 5, 2023

Conversation

borjamunozf
Copy link
Contributor

Hi.

Coming from this discussion started by @Xuanwo , it's has been considered a good idea to include the version info when running the sccache --show-stats command.

I have included a basic solution, directly included & calling the env! macro to get the CARGO_PKG_VERSION.
One of the pending confirmations should be the display info of this new version field, as it has been mentioned that it should be explicit regarding it's the client version.

It's not a big thing, but hope to help a bit with this cool project besides my ongoing learning of Rust.
Sorry in advance for any mistake.

Thanks.

src/server.rs Show resolved Hide resolved
@sylvestre sylvestre force-pushed the version-server-stats branch from 3705606 to da472ba Compare January 28, 2023 17:28
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Base: 30.93% // Head: 30.95% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (c377e28) compared to base (8b11e89).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
+ Coverage   30.93%   30.95%   +0.02%     
==========================================
  Files          48       48              
  Lines       16625    16633       +8     
  Branches     7976     7982       +6     
==========================================
+ Hits         5143     5149       +6     
- Misses       6066     6070       +4     
+ Partials     5416     5414       -2     
Impacted Files Coverage Δ
src/server.rs 31.67% <50.00%> (+0.70%) ⬆️
src/test/tests.rs 33.33% <100.00%> (-0.23%) ⬇️
src/util.rs 34.85% <0.00%> (-1.31%) ⬇️
src/compiler/c.rs 38.44% <0.00%> (-0.23%) ⬇️
src/compiler/msvc.rs 43.12% <0.00%> (-0.14%) ⬇️
src/lib.rs 10.79% <0.00%> (ø)
src/mock_command.rs 52.05% <0.00%> (ø)
src/compiler/args.rs 62.32% <0.00%> (ø)
src/compiler/rust.rs 33.79% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre
Copy link
Collaborator

please add a test to make sure we don't regress in the future.
Probably something like:

fn test_basic_compile(compiler: Compiler, tempdir: &Path) {

@borjamunozf
Copy link
Contributor Author

please add a test to make sure we don't regress in the future. Probably something like:

fn test_basic_compile(compiler: Compiler, tempdir: &Path) {

Agree. Nevertheless, I also have found this test, which could fit better & restricted to this? Add an extra assert or create a new one (perhaps too much for now & just a new static field)

fn test_server_stats() {

Maybe I'm overthinking it too much...

@sylvestre
Copy link
Collaborator

Sure, as you wish :)

@sylvestre
Copy link
Collaborator

please run rustfmt on your change

@sylvestre sylvestre force-pushed the version-server-stats branch from 18794ed to c377e28 Compare January 31, 2023 10:42
@sylvestre
Copy link
Collaborator

Sorry for the latency, i wanted to verify that json file also contained it :) (and it does)

@sylvestre sylvestre merged commit f8972dc into mozilla:main Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants