Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump OpenDAL and remove hyperx #1591

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Feb 7, 2023

Signed-off-by: Xuanwo github@xuanwo.io

This PR will bump opendal to latest version. The whole changelog could be visited at https://docs.rs/opendal/0.26.2/opendal/docs/changelog/index.html

Also, this PR removed conflict deps hyperx. hyperx is out of maintain and we can use http and mime to replace the features provided by hyperx.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Feb 8, 2023

The failed CI is related to rust-lang/rust#107730 (Yep, we are meeting an ICE)

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Feb 9, 2023

cc @sylvestre, please help re-run this CI, I believe the ICE has been addressed in the nightly rust.

@codecov-commenter
Copy link

Codecov Report

Base: 30.93% // Head: 30.79% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (08c0a0a) compared to base (8b11e89).
Patch coverage: 12.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
- Coverage   30.93%   30.79%   -0.14%     
==========================================
  Files          48       48              
  Lines       16625    16544      -81     
  Branches     7976     7999      +23     
==========================================
- Hits         5143     5095      -48     
- Misses       6066     6180     +114     
+ Partials     5416     5269     -147     
Impacted Files Coverage Δ
src/cache/azure.rs 0.00% <0.00%> (ø)
src/cache/gha.rs 0.00% <0.00%> (ø)
src/cache/memcached.rs 0.00% <0.00%> (ø)
src/cache/redis.rs 0.00% <0.00%> (ø)
src/dist/client_auth.rs 0.00% <0.00%> (ø)
src/dist/http.rs 0.00% <0.00%> (ø)
src/util.rs 37.15% <ø> (+0.99%) ⬆️
src/cache/gcs.rs 10.20% <25.00%> (ø)
src/cache/s3.rs 48.93% <40.00%> (+1.11%) ⬆️
src/server.rs 31.04% <50.00%> (+0.08%) ⬆️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre sylvestre merged commit c5cc92e into mozilla:main Feb 11, 2023
@Xuanwo Xuanwo deleted the bump-opendal branch February 12, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants