Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix upload artifact failure #1598

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Feb 12, 2023

Signed-off-by: Xuanwo github@xuanwo.io

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2023

Codecov Report

Base: 30.85% // Head: 30.81% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (4307ad3) compared to base (b8ba6b6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
- Coverage   30.85%   30.81%   -0.04%     
==========================================
  Files          48       48              
  Lines       16602    16602              
  Branches     8008     8008              
==========================================
- Hits         5122     5116       -6     
- Misses       6220     6223       +3     
- Partials     5260     5263       +3     
Impacted Files Coverage Δ
src/cache/disk.rs 34.24% <0.00%> (-1.37%) ⬇️
src/mock_command.rs 51.51% <0.00%> (-1.14%) ⬇️
src/test/utils.rs 36.36% <0.00%> (-1.02%) ⬇️
src/compiler/c.rs 37.70% <0.00%> (-0.46%) ⬇️
src/util.rs 36.80% <0.00%> (-0.35%) ⬇️
src/lru_disk_cache/mod.rs 41.15% <0.00%> (-0.31%) ⬇️
src/server.rs 31.56% <0.00%> (-0.11%) ⬇️
src/compiler/compiler.rs 36.03% <0.00%> (-0.08%) ⬇️
src/lib.rs 10.99% <0.00%> (-0.06%) ⬇️
src/compiler/rust.rs 33.46% <0.00%> (+0.06%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title Try to debug artifact failure ci: Fix upload artifact failure Feb 12, 2023
@Xuanwo Xuanwo marked this pull request as ready for review February 12, 2023 16:06
@sylvestre
Copy link
Collaborator

is it really fixing it or helping with debugging?

@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Feb 14, 2023

helping with debugging?

helping for debugging, now we can get the artifact failure as expected.

@sylvestre sylvestre merged commit 59e906d into mozilla:main Feb 17, 2023
@Xuanwo Xuanwo deleted the debug-actions branch February 22, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants