Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fs_err for sake of better io errors #1616

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Conversation

drahnr
Copy link
Collaborator

@drahnr drahnr commented Feb 21, 2023

Provides path names of failing io operations where possible by default, both in the resulting binaries which ease debugging of i.e. selinux or seccomp filters, without resorting to strace, but also local unit test file operations.

The identical change was made in cachepot

Provides path names of failing io operations where possible by default,
both in the resulting binaries which ease debugging of i.e. selinux or
seccomp filters, without resorting to strace, but also local unit test
file operations.
@drahnr drahnr requested a review from sylvestre February 21, 2023 07:07
@drahnr drahnr changed the title use fs_err use fs_err for sake of better io errors Feb 21, 2023
@drahnr
Copy link
Collaborator Author

drahnr commented Feb 21, 2023

Superseeds #1611 which covers two instances, where this covers all io operations except for two, where the std::fs::File API is required for external crates.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Base: 30.80% // Head: 30.91% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (7753824) compared to base (4b53aca).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1616      +/-   ##
==========================================
+ Coverage   30.80%   30.91%   +0.10%     
==========================================
  Files          49       49              
  Lines       16618    16649      +31     
  Branches     8049     8055       +6     
==========================================
+ Hits         5120     5147      +27     
- Misses       6216     6229      +13     
+ Partials     5282     5273       -9     
Impacted Files Coverage Δ
src/cache/cache.rs 38.20% <ø> (-0.38%) ⬇️
src/commands.rs 19.51% <ø> (ø)
src/compiler/c.rs 38.16% <ø> (ø)
src/compiler/clang.rs 53.11% <ø> (ø)
src/compiler/compiler.rs 36.03% <ø> (+0.07%) ⬆️
src/compiler/diab.rs 47.96% <ø> (+0.27%) ⬆️
src/compiler/gcc.rs 55.47% <ø> (+1.03%) ⬆️
src/compiler/msvc.rs 42.80% <ø> (ø)
src/compiler/nvcc.rs 35.32% <ø> (ø)
src/compiler/rust.rs 33.81% <0.00%> (-0.14%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre sylvestre merged commit fe295fa into main Feb 21, 2023
@sylvestre sylvestre deleted the bernhard-migrate-to-fs-err branch February 21, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants