Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip env vars #1663

Merged
merged 1 commit into from
Mar 17, 2023
Merged

strip env vars #1663

merged 1 commit into from
Mar 17, 2023

Conversation

drahnr
Copy link
Collaborator

@drahnr drahnr commented Mar 17, 2023

Resolves a FIXME

Currently these variables are only ignored for a specific case
but it makes sense to retain that in the general case too.
@drahnr drahnr force-pushed the bernhard-env-vars branch from bc87a31 to 770b5eb Compare March 17, 2023 08:08
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: +0.07 🎉

Comparison is base (bc0718f) 29.58% compared to head (bc87a31) 29.66%.

❗ Current head bc87a31 differs from pull request most recent head 770b5eb. Consider uploading reports for the commit 770b5eb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1663      +/-   ##
==========================================
+ Coverage   29.58%   29.66%   +0.07%     
==========================================
  Files          49       49              
  Lines       17030    17029       -1     
  Branches     8209     8202       -7     
==========================================
+ Hits         5039     5051      +12     
+ Misses       6997     6980      -17     
- Partials     4994     4998       +4     
Impacted Files Coverage Δ
src/cmdline.rs 22.72% <84.61%> (+8.44%) ⬆️

... and 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sylvestre
Copy link
Collaborator

Looks good. Do you think it could be tested to make sure we don't regress in the future ?

@drahnr
Copy link
Collaborator Author

drahnr commented Mar 17, 2023

I can't reproduce the outlined issue with a fresh build, so I'd say no for the time being.

@sylvestre sylvestre merged commit 098ab80 into main Mar 17, 2023
@sylvestre sylvestre deleted the bernhard-env-vars branch March 17, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants