Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add possibility to configure key prefix (Redis, MemCached) #2084

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

AJIOB
Copy link
Contributor

@AJIOB AJIOB commented Feb 11, 2024

  • Add possibility to configure key prefix for Redis & MemCached
  • Unify Redis & MemCached expiraction time
  • Actualize configuration docs

@AJIOB AJIOB changed the title Draft: Unify config values format Unify config values format Feb 11, 2024
@AJIOB AJIOB changed the title Unify config values format Unify config values format (Redis, MemCached) Feb 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (ffe3070) 30.77% compared to head (2131617) 30.70%.

Files Patch % Lines
src/config.rs 15.62% 18 Missing and 9 partials ⚠️
src/cache/cache.rs 0.00% 6 Missing ⚠️
src/cache/memcached.rs 0.00% 3 Missing ⚠️
src/cache/redis.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2084      +/-   ##
==========================================
- Coverage   30.77%   30.70%   -0.08%     
==========================================
  Files          52       52              
  Lines       19913    19944      +31     
  Branches     9630     9658      +28     
==========================================
- Hits         6129     6123       -6     
- Misses       7959     7990      +31     
- Partials     5825     5831       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre
Copy link
Collaborator

if i understand correctly this PR, it isn't going to change the behavior of existing configurations, right?

@AJIOB
Copy link
Contributor Author

AJIOB commented Feb 11, 2024

@sylvestre, yes, you are right.

I am not changed the current configuration API. Just documenting, unifying & extending it.

@AJIOB AJIOB changed the title Unify config values format (Redis, MemCached) Add possibility to configure key prefix (Redis, MemCached) Feb 11, 2024
@AJIOB AJIOB changed the title Add possibility to configure key prefix (Redis, MemCached) feat: Add possibility to configure key prefix (Redis, MemCached) Feb 11, 2024
@AJIOB
Copy link
Contributor Author

AJIOB commented Feb 13, 2024

@Xuanwo, hello.

What I need to do for merging this PR?

Do we have some problems with this changes? Or I need to split it to few ones?

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo
Copy link
Collaborator

Xuanwo commented Feb 14, 2024

Those changes LGTM! cc @sylvestre do you want to take another look?

@sylvestre sylvestre merged commit e445b79 into mozilla:main Feb 15, 2024
49 checks passed
@sylvestre
Copy link
Collaborator

thanks!

@AJIOB AJIOB deleted the AJIOB/unify-values-format branch February 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants