-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add possibility to configure key prefix (Redis, MemCached) #2084
Conversation
AJIOB
commented
Feb 11, 2024
- Add possibility to configure key prefix for Redis & MemCached
- Unify Redis & MemCached expiraction time
- Actualize configuration docs
* Fix config values loading for memcached & redis
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2084 +/- ##
==========================================
- Coverage 30.77% 30.70% -0.08%
==========================================
Files 52 52
Lines 19913 19944 +31
Branches 9630 9658 +28
==========================================
- Hits 6129 6123 -6
- Misses 7959 7990 +31
- Partials 5825 5831 +6 ☔ View full report in Codecov by Sentry. |
if i understand correctly this PR, it isn't going to change the behavior of existing configurations, right? |
@sylvestre, yes, you are right. I am not changed the current configuration API. Just documenting, unifying & extending it. |
@Xuanwo, hello. What I need to do for merging this PR? Do we have some problems with this changes? Or I need to split it to few ones? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Those changes LGTM! cc @sylvestre do you want to take another look? |
thanks! |