Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[Enhancement] iOS Apple or Android logos should be displayed on "Get the App" button depending on supported platform #3928

Open
SoftVision-PaulOiegas opened this issue Oct 31, 2018 · 2 comments
Labels
[QA]:Enhancement Label for QA to mark enhancements logged

Comments

@SoftVision-PaulOiegas
Copy link

[Affected versions]:

  • Firefox 63.0 and above

[Affected Platforms]:

  • All Windows
  • All Mac OS
  • All Linux

[Prerequisites]:

  • Set the "extensions.webapi.testing" boolean pref to "true" in "about:config" page.

[Steps to reproduce]:

  1. Open Firefox browser and navigate to https://testpilot.dev.mozaws.net.
  2. Observe the Lockbox iOS "Get the App" button from Featured experiment section.
  3. Scroll down and click on Notes experiment card.
  4. Observe the "Get the App" button for Notes Android app.

[Expected result]:

  • "Get the App" button displays the iOS Apple or Android logos depending on experiment platforms supported.

[Actual result]:

  • There is no difference between iOS or Android "Get the App" buttons, a mobile phone icon is displayed for both.

[Notes]:

  • Here is a screenshot of the issue:

ios vs android

@SoftVision-PaulOiegas SoftVision-PaulOiegas added the [QA]:Enhancement Label for QA to mark enhancements logged label Oct 31, 2018
@KhushilMistry
Copy link

KhushilMistry commented Nov 2, 2018

Hey, I want to work on this issue. Will make a PR soon.
I have a question : Should the color be the same for both the button i.e. green ? Or you want blue for iOS experiment and green for Android experiment ? Something like following :

screenshot 2018-11-02 at 4 38 09 pm
screenshot 2018-11-02 at 4 38 43 pm

Experiement Page has different design now.

screenshot 2018-11-02 at 3 28 31 pm

screenshot 2018-11-02 at 3 28 46 pm

@SoftVision-PaulOiegas
Copy link
Author

hey @KhushilMistry, please don't rush with this since it's an enhancement proposal and wasn't triaged yet. We'll need to see if @johngruen thinks it adds value to the current implementation or not first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[QA]:Enhancement Label for QA to mark enhancements logged
Projects
None yet
Development

No branches or pull requests

2 participants