Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata extraction for large ELF files (#2285) #2286

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

bendk
Copy link
Contributor

@bendk bendk commented Oct 24, 2024

Symbol table entries store a 16-bit index for their section header. If the index overflows 16-bits then it's stored in a separate section instead.

References:

@bendk bendk requested a review from a team as a code owner October 24, 2024 21:39
@bendk bendk requested review from jeddai and removed request for a team October 24, 2024 21:39
@bendk bendk force-pushed the push-nmmotszxnykz branch 2 times, most recently from 49ba165 to ef8fc9b Compare October 24, 2024 22:54
Copy link
Member

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! changelog?

Symbol table entries store a 16-bit index for their section header.  If
the index overflows 16-bits then it's stored in a separate section
instead.

References:

- https://refspecs.linuxbase.org/elf/gabi4+/ch4.symtab.html
- https://docs.oracle.com/cd/E19683-01/817-3677/chapter6-94076/index.html
@bendk bendk force-pushed the push-nmmotszxnykz branch from ef8fc9b to 111aa07 Compare October 25, 2024 13:26
@jhugman
Copy link
Contributor

jhugman commented Oct 25, 2024

Amazing. Thanks for the fast turn around.

@bendk bendk merged commit 279a587 into mozilla:main Oct 25, 2024
5 checks passed
@bendk bendk deleted the push-nmmotszxnykz branch October 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants