feat: Support chromium-based browsers as web-ext run targets #1392

rpl · 2018-11-03T18:27:50Z

This PR introduces a new 'chromium' target and a new --chromium-binary cli option
(which covers #809 and part of #1130).

Internally it uses the chrome-launcher npm package to manage the chromium instance and so by default it tries to discover and launch the Chrome or Chromium version installed in the system.

Nevertheless other Chromium-based browsers that support extensions (like Opera and Vivaldi) can be launched using this target (with the addition of the --chromium-binary option):

TODO:

add tests for the chromium extension-runner module

coveralls · 2018-11-03T18:52:03Z

Coverage remained the same at 100.0% when pulling 6ac949e on rpl:feat/chrome-extension-runner into 21aa78b on mozilla:master.

src/extension-runners/chromium.js

src/extension-runners/base.js

src/extension-runners/chromium.js

src/program.js

src/extension-runners/chromium.js

patch rebased as agreed, clearing the existing pending review requests

rpl · 2019-08-02T17:23:06Z

@Rob--W as we agreed I've rebased and adapted this patch on top of the changes introduced in #1645 (and also looked into making the change to the package-lock.json file small and limited to just the new dependencies).

package.json

src/extension-runners/chromium.js

tests/functional/test.cli.run.js

src/extension-runners/chromium.js

Rob--W

Looks mostly good; just a few minor comments.

tests/unit/test-extension-runners/test.chromium.js

rpl · 2019-08-26T16:58:04Z

I'm going to rebase this PR on top of #1685 (because the CI job will fail for the eslint-utils security vulnerability detected in the npm audit step).

…chromium extension runner

…le change related to chrome-launcher

…ing async setup to be completed

tests/unit/test-extension-runners/test.chromium.js

src/extension-runners/chromium.js

… run method

Created helper fn and fixed flow small fix small fix Correcting flow ES LINT rewriting tests updating test case Squashing all commits small fix small fix Correcting flow ES LINT rewriting tests updating test case requested changes rebasing changed fake-firefox-binary changed fake-firefox-binary chore(deps): update dependency babel-plugin-istanbul to v5.2.0 (mozilla#1667) chore(deps): update dependency eslint-plugin-flowtype to v3.12.2 (mozilla#1668) chore(deps): update dependency conventional-changelog-cli to v2.0.23 (mozilla#1670) chore(deps): update dependency webpack to v4.39.0 (mozilla#1651) fix(deps): update dependency source-map-support to v0.5.13 (mozilla#1671) chore(deps): update dependency webpack to v4.39.1 (mozilla#1672) chore(deps): update dependency eslint-plugin-flowtype to v3.13.0 (mozilla#1673) chore(deps): update dependency coveralls to v3.0.6 (mozilla#1677) chore(deps): update dependency sinon to v7.4.1 (mozilla#1676) chore(deps): update dependency eslint-plugin-flowtype to v4 (mozilla#1678) chore: Update eslint to v6.2.2 and babel-eslint to v.1.0.3 (mozilla#1685) - eslint 6.2.2 fix a CI failure due to vulnerable eslint-utils dependency - babel-eslint 1.0.3 fix issues with no-unused vars false positive (See eslint/eslint#12117 and babel/babel-eslint#791) feat: Support chromium-based browsers as web-ext run targets (mozilla#1392)

…556fffa13cc56 parent 5622838 author Rishabh Budhiraja <rishabh.budhiraja@gmail.com> 1564321912 +0530 committer Rishabh Budhiraja <rishabh.budhiraja@gmail.com> 1567513919 +0530 # This is a combination of 3 commits.tree 6d3c63a3b96959cabfa8294f37e556fffa13cc56 parent 5622838 author Rishabh Budhiraja <rishabh.budhiraja@gmail.com> 1564321912 +0530 committer Rishabh Budhiraja <rishabh.budhiraja@gmail.com> 1567513781 +0530 # This is a combination of 2 commits. # This is the 1st commit message: Fixes method for finding default port Created helper fn and fixed flow small fix small fix Correcting flow ES LINT rewriting tests updating test case Squashing all commits small fix small fix Correcting flow ES LINT rewriting tests updating test case requested changes rebasing changed fake-firefox-binary changed fake-firefox-binary chore(deps): update dependency babel-plugin-istanbul to v5.2.0 (mozilla#1667) chore(deps): update dependency eslint-plugin-flowtype to v3.12.2 (mozilla#1668) chore(deps): update dependency conventional-changelog-cli to v2.0.23 (mozilla#1670) chore(deps): update dependency webpack to v4.39.0 (mozilla#1651) fix(deps): update dependency source-map-support to v0.5.13 (mozilla#1671) chore(deps): update dependency webpack to v4.39.1 (mozilla#1672) chore(deps): update dependency eslint-plugin-flowtype to v3.13.0 (mozilla#1673) chore(deps): update dependency coveralls to v3.0.6 (mozilla#1677) chore(deps): update dependency sinon to v7.4.1 (mozilla#1676) chore(deps): update dependency eslint-plugin-flowtype to v4 (mozilla#1678) chore: Update eslint to v6.2.2 and babel-eslint to v.1.0.3 (mozilla#1685) - eslint 6.2.2 fix a CI failure due to vulnerable eslint-utils dependency - babel-eslint 1.0.3 fix issues with no-unused vars false positive (See eslint/eslint#12117 and babel/babel-eslint#791) feat: Support chromium-based browsers as web-ext run targets (mozilla#1392) # This is the commit message mozilla#2: chore(deps): update dependency babel-plugin-istanbul to v5.2.0 (mozilla#1667) # This is the commit message mozilla#3: chore(deps): update dependency conventional-changelog-cli to v2.0.23 (mozilla#1670) # This is the commit message mozilla#5: fix(deps): update dependency source-map-support to v0.5.13 (mozilla#1671)

parent 5622838 author Rishabh Budhiraja <rishabh.budhiraja@gmail.com> 1564321912 +0530 committer Rishabh Budhiraja <rishabh.budhiraja@gmail.com> 1567514055 +0530 # This is a combination of 5 commits.tree 6d3c63a3b96959cabfa8294f37e556fffa13cc56 parent 5622838 author Rishabh Budhiraja <rishabh.budhiraja@gmail.com> 1564321912 +0530 committer Rishabh Budhiraja <rishabh.budhiraja@gmail.com> 1567513919 +0530 # This is a combination of 3 commits.tree 6d3c63a3b96959cabfa8294f37e556fffa13cc56 parent 5622838 author Rishabh Budhiraja <rishabh.budhiraja@gmail.com> 1564321912 +0530 committer Rishabh Budhiraja <rishabh.budhiraja@gmail.com> 1567513781 +0530 # This is a combination of 2 commits. # This is the 1st commit message: Fixes method for finding default port Created helper fn and fixed flow small fix small fix Correcting flow ES LINT rewriting tests updating test case Squashing all commits small fix small fix Correcting flow ES LINT rewriting tests updating test case requested changes rebasing changed fake-firefox-binary changed fake-firefox-binary chore(deps): update dependency babel-plugin-istanbul to v5.2.0 (mozilla#1667) chore(deps): update dependency eslint-plugin-flowtype to v3.12.2 (mozilla#1668) chore(deps): update dependency conventional-changelog-cli to v2.0.23 (mozilla#1670) chore(deps): update dependency webpack to v4.39.0 (mozilla#1651) fix(deps): update dependency source-map-support to v0.5.13 (mozilla#1671) chore(deps): update dependency webpack to v4.39.1 (mozilla#1672) chore(deps): update dependency eslint-plugin-flowtype to v3.13.0 (mozilla#1673) chore(deps): update dependency coveralls to v3.0.6 (mozilla#1677) chore(deps): update dependency sinon to v7.4.1 (mozilla#1676) chore(deps): update dependency eslint-plugin-flowtype to v4 (mozilla#1678) chore: Update eslint to v6.2.2 and babel-eslint to v.1.0.3 (mozilla#1685) - eslint 6.2.2 fix a CI failure due to vulnerable eslint-utils dependency - babel-eslint 1.0.3 fix issues with no-unused vars false positive (See eslint/eslint#12117 and babel/babel-eslint#791) feat: Support chromium-based browsers as web-ext run targets (mozilla#1392) # This is the commit message mozilla#2: chore(deps): update dependency babel-plugin-istanbul to v5.2.0 (mozilla#1667) # This is the commit message mozilla#3: chore(deps): update dependency conventional-changelog-cli to v2.0.23 (mozilla#1670) # This is the commit message mozilla#5: fix(deps): update dependency source-map-support to v0.5.13 (mozilla#1671) # This is the commit message mozilla#7: chore(deps): update dependency eslint-plugin-flowtype to v3.13.0 (mozilla#1673) # This is the commit message mozilla#9: chore(deps): update dependency coveralls to v3.0.6 (mozilla#1677) # This is the commit message mozilla#10: chore(deps): update dependency sinon to v7.4.1 (mozilla#1676)

rpl force-pushed the feat/chrome-extension-runner branch from 20d7194 to 12f0998 Compare November 3, 2018 18:37

rpl force-pushed the feat/chrome-extension-runner branch from 12f0998 to ff49ae4 Compare November 3, 2018 18:53

Rob--W previously requested changes Nov 7, 2018

View reviewed changes

rpl mentioned this pull request Mar 25, 2019

feat: Adds binaryArgs to pass additional flags to Firefox binary #1563

Merged

rpl force-pushed the feat/chrome-extension-runner branch from ff49ae4 to cfd3c56 Compare June 30, 2019 17:15

rpl requested a review from Rob--W June 30, 2019 17:18

rpl force-pushed the feat/chrome-extension-runner branch from fb74caf to 437fe65 Compare July 1, 2019 11:15

rpl force-pushed the feat/chrome-extension-runner branch from 437fe65 to 7d8a147 Compare August 2, 2019 16:03

Rob--W reviewed Aug 3, 2019

View reviewed changes

Rob--W approved these changes Aug 3, 2019

View reviewed changes

Rob--W reviewed Aug 26, 2019

View reviewed changes

tests/unit/test-extension-runners/test.chromium.js Outdated Show resolved Hide resolved

rpl added 6 commits August 26, 2019 18:59

feat: Support chromium-based browsers as web-ext run targets

2bd8ef9

chore: Added test assertion for the wss socket error handling in the …

c273ba5

…chromium extension runner

chore: Link to comment related to followup improvements

5e1c094

chore: minor tweaks on manager extension background page

21d6134

chore: update chrome-launcher and ws deps and fix backward incompatib…

1e07786

…le change related to chrome-launcher

fix: Chromium extension runner's exit method should await for an ongo…

d6168a6

…ing async setup to be completed

rpl force-pushed the feat/chrome-extension-runner branch from 837195f to d6168a6 Compare August 26, 2019 16:59

chore: small tweak on the wss socket error test case

b6a0423

Rob--W reviewed Aug 26, 2019

View reviewed changes

tests/unit/test-extension-runners/test.chromium.js Outdated Show resolved Hide resolved

src/extension-runners/chromium.js Outdated Show resolved Hide resolved

rpl added 2 commits August 26, 2019 19:53

chore: just use sinon.spy to spy fakeSocket.on method

c878740

chore: Set _promiseSetupDone unconditionally in the chromium runner's…

0940014

… run method

Rob--W approved these changes Aug 26, 2019

View reviewed changes

This was referenced Aug 27, 2019

chromium extension-runner reloadAllExtensions should wait wssBroadcast to be processed by the connected clients #1686

Closed

chromium extension-runner reloadExtensionBySourceDir should be able to identify and reload the single target extension #1687

Open

rpl added 2 commits August 27, 2019 15:57

chore: removed redundant empty line

f32e844

chore: link TODOs to their related followup issue

6ac949e

Rob--W approved these changes Aug 27, 2019

View reviewed changes

rpl merged commit 961da0c into mozilla:master Aug 27, 2019

rpl mentioned this pull request Sep 2, 2019

fix: Choose a random free tcp port to be used for the Firefox Desktop remote debugging server #1669

Merged

Misaka-0x447f mentioned this pull request Sep 5, 2019

Support chromium based browser in toolchain DimensionDev/Maskbook#160

Closed

rpl mentioned this pull request Sep 19, 2019

Use web-ext to run an extension in Google Chrome #809

Closed

david-tejada mentioned this pull request Jul 5, 2022

Add CONTRIBUTING.md doc david-tejada/rango#48

Merged

makiisthenes mentioned this pull request Feb 2, 2024

[Snyk] Security upgrade sign-addon from 3.1.0 to 6.4.0 makiisthenes/web-ext#12

Open

terrorizer1980 mentioned this pull request Feb 2, 2024

[Snyk] Security upgrade sign-addon from 3.3.0 to 6.4.0 terrorizer1980/web-ext#20

Open

sirinartk mentioned this pull request Feb 2, 2024

[Snyk] Security upgrade sign-addon from 0.3.1 to 6.4.0 sirinartk/web-ext#34

Open

aliceUnhinged613 mentioned this pull request Feb 2, 2024

[Snyk] Security upgrade sign-addon from 3.0.0 to 6.4.0 aliceUnhinged613/web-ext#32

Open

Oleksandr1201vsp mentioned this pull request Feb 3, 2024

[Snyk] Security upgrade sign-addon from 0.3.1 to 6.4.0 Oleksandr1201vsp/web-ext#32

Open

patooworld mentioned this pull request Feb 3, 2024

[Snyk] Security upgrade sign-addon from 6.0.0 to 6.4.0 patooworld/web-ext#9

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Support chromium-based browsers as web-ext run targets #1392

feat: Support chromium-based browsers as web-ext run targets #1392

rpl commented Nov 3, 2018 •

edited

Loading

coveralls commented Nov 3, 2018 •

edited

Loading

rpl commented Aug 2, 2019

Rob--W left a comment

rpl commented Aug 26, 2019

feat: Support chromium-based browsers as web-ext run targets #1392

feat: Support chromium-based browsers as web-ext run targets #1392

Conversation

rpl commented Nov 3, 2018 • edited Loading

coveralls commented Nov 3, 2018 • edited Loading

rpl commented Aug 2, 2019

Rob--W left a comment

Choose a reason for hiding this comment

rpl commented Aug 26, 2019

rpl commented Nov 3, 2018 •

edited

Loading

coveralls commented Nov 3, 2018 •

edited

Loading