Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running extensions in both Chrome and Firefox leaves temporary directories #1981

Open
ghostwords opened this issue Jul 30, 2020 · 3 comments

Comments

@ghostwords
Copy link

Is this a feature request or a bug?

Bug

What is the current behavior?

Running extensions in both Chrome and Firefox still leaves temporary directories. This happens despite web-ext logging that it cleans up some temp directory on exit in verbose mode. (The directory logged is indeed missing, but others remain.)

Here are some recent leftover folders in /tmp/:

.com.google.Chrome.tV0jJO
tmp-web-ext--2445-Rid4u33i0TaN
.com.google.Chrome.1YiHq1
tmp-web-ext--9065-2sTtAd1ZXCx2
lighthouse.cc52DU2
lighthouse.elq0cnz
lighthouse.1p1kCZO
lighthouse.aEuUs7s
lighthouse.GxOVGAS
lighthouse.LTtzBYw
vxRzd7e
lighthouse.mXLE5jI
tmp-web-ext--8248-8w2G2D5WDdNB

The "lighthouse", "Chrome" and "vxRzd7e"-like folders come from Chrome, I think. "tmp-web-ext" folders are from Firefox.

"lighthouse" folders in particular seem to sometimes grow to hundreds of megabytes in size when a web-ext run session is left running for days.

Versions

web-ext 5.0.0
Various versions (both latest and older) of Firefox and Chrome.

@ghostwords
Copy link
Author

#1957 sounds related.

@Rob--W
Copy link
Member

Rob--W commented Jul 30, 2020

Confirmed with -t chromium, but not reproducible with Firefox. Are you seeing this with web-ext run (Firefox)?

We should either ensure that the directory content is destroyed, or call tmp.setGracefulCleanup() in https://github.com/mozilla/web-ext/blob/cfc49ce803a9a320d06af5871a2e3aa8a8c533b5/src/util/temp-dir.js

@ghostwords
Copy link
Author

ghostwords commented Jul 30, 2020

Yes, the tmp-web-ext folders are from Firefox runs. I just tried again with the latest version of Firefox and got two new folders with names like "Temp-075a8052-2cd9-4460-8ac9-13e76c3aa77e". Plus there are a bunch of "rust_mozprofile.pspDgJWpvtWe" folders too, also probably from Firefox. These are all in /tmp. It's possible some of these are not from web-ext, but I'm sure a lot of them are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants