fix: Bump minimum nodejs version supported to v12 #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does bump the minimum nodejs version supported to v12 (would likely still work for now on nodejs v10 but it will print a warning when installed from npm, with yarn the user will have to explicitly pass the yarn CLI option to ask yarn to allow installing the package without enforcing the mininum nodejs version).
Along with bumping the minimum supported version, it does also add nodejs v15 to the nodejs versions we do run as part of the CI jobs (which is meant to be replaced with nodejs 16 once it will be released).