-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Limit reloads to enabled extensions in chrome extension runner #2365
Conversation
@fregante this looks definitely like a reasonable short term workaround to fix #2364, thanks for filing the issue and for looking into a fix! The CI job failure is due to the linting of the commit message. That step of the CI job will validate the commit message that github chooses by default when the PR is squashed and merged, and so:
And so for fixing that CI job failure you just need to reword the commit message as "fix: Limit reloads to enabled extensions" (or "fix: Limit reloads to enabled extensions in chrome extension runner" to make it clear which of the extension runner the fix is about) and force push it here. |
I can't check it out right now, but I added 2 commits that might make it pass 😅 |
Codecov Report
@@ Coverage Diff @@
## master #2365 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 32 32
Lines 1701 1701
=======================================
Hits 1699 1699
Misses 2 2
Continue to review full report at Codecov.
|
Demo of this piece of code working locally: You can see that the extension on the right is reloaded while the disabled one stays disabled: Screen.Recording.6.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fregante Thank you! (also for recording a screencast to quickly let me see the fix in use ❤️ )
web-ext run
should not enable disabled extensions #2364