Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/space 頁面下方的 keyholder avatar 比例錯誤 #568

Open
irvin opened this issue Sep 14, 2017 · 3 comments
Open

/space 頁面下方的 keyholder avatar 比例錯誤 #568

irvin opened this issue Sep 14, 2017 · 3 comments

Comments

@irvin
Copy link
Member

irvin commented Sep 14, 2017

ref #549, PR #567 把圖片補回來了,可是圖片比例不正確
要改成讓他自動填滿

@robertmodesty
Copy link
Contributor

這是因為 css/mozspacetp.css 會依照圖片的長寬比決定顯示的橢圓形範圍長寬,解決方法兩個,第一是改 css,第二是把新的圖片裁切成正方形圖片。第一種方法比較簡單,但是會拉伸圖片,使得人像變胖或變瘦長。第二種方法比較沒有變通性,要改好幾張圖片,但是可以調得比較好看。

@irvin
Copy link
Member Author

irvin commented Sep 14, 2017

直接改 html 結構讓圖片變成上層 a 容器的背景也行,就會自動等比例填滿。

@robertmodesty
Copy link
Contributor

填滿的方法會讓 bob 跟極地狐都變胖,考慮之後我還是直接把圖片切成正方形就好。請見 #569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants