Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ansi_term and colored output #20

Merged
merged 1 commit into from
May 24, 2017
Merged

Remove ansi_term and colored output #20

merged 1 commit into from
May 24, 2017

Conversation

syxolk
Copy link
Collaborator

@syxolk syxolk commented May 24, 2017

Remove any color output because of:

  • insufficient cross-compatibility of ansi_term
  • bad alternatives (termcolor, term-painter)
  • no detection for stdout piping

@mp4096
Copy link
Owner

mp4096 commented May 24, 2017

Thanks! I'm ok with the changes, let's just wait till all Travis checks pass.

@mp4096 mp4096 self-requested a review May 24, 2017 20:56
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.337% when pulling 3a8aaa9 on syxolk:no-colors into 2aee54e on mp4096:master.

@mp4096 mp4096 merged commit f5b1928 into mp4096:master May 24, 2017
@mp4096 mp4096 mentioned this pull request May 24, 2017
Closed
4 tasks
@syxolk syxolk deleted the no-colors branch May 25, 2017 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp4096 mp4096 mp4096 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syxolk @mp4096 @coveralls