-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jekyll 3 compatiblity #20
Comments
I had a quick glimpse into the changes of Jekyll and I guess it should be sufficient to use However, I'm not entirely sure as I didn't check all the Jekyll changes. You should probably also consider investigating what @mnot did in commit 77941d. He's not using the I'd be happy to receive feedback on this! :) |
I went with hooks approach as I believe they're more elegant: https://github.com/rr-/sakuya.pl/commit/100a3ab5abbbe0796e80efabb4b8579551ce326b |
I found jekyll-static-comments to be incompatible with Jekyll 3 as the to_liquid method moved to
Convertible
in 3.0 and the they seem to use Drops from 3.1 on. The latest Jekyll version I got the plugin to work with is 2.5.3. Any plans to update the plugin?The text was updated successfully, but these errors were encountered: