Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow setting Braze instance and override notification handling #87

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

einsteinx2
Copy link
Contributor

Summary

Due to the partner SDK changes (from Appboy to Braze) the implementation changed a bit and the kit was no longer to fully handle attribution to Braze for notifications that open the app (cold start).

These changes allow customers to inform the kit that they will handle notifications in their app code as well as allowing them to set their own braze instance to the kit (which is required to handle notifications manually).

Docs updates will be forthcoming.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Heavily tested pairing with Michael G

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit a355dba into development Feb 20, 2024
3 checks passed
@einsteinx2 einsteinx2 deleted the feat/add-option-disable-notification-handling branch February 20, 2024 17:54
mparticle-automation added a commit that referenced this pull request Feb 20, 2024
# [8.4.0](v8.3.1...v8.4.0) (2024-02-20)

### Features

* Allow setting Braze instance and override notification handling ([#87](#87)) ([a355dba](a355dba))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 8.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mparticle-automation added a commit that referenced this pull request Feb 21, 2024
# [8.4.0](v8.3.1...v8.4.0) (2024-02-21)

### Features

* Allow setting Braze instance and override notification handling ([#87](#87)) ([c3c76c1](c3c76c1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants