Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo warning should be shown only if embedded by MPDS #21

Open
blokhin opened this issue Mar 25, 2024 · 3 comments
Open

Demo warning should be shown only if embedded by MPDS #21

blokhin opened this issue Mar 25, 2024 · 3 comments
Assignees
Labels

Comments

@blokhin
Copy link
Member

blokhin commented Mar 25, 2024

currently shown always:

title \You are using the limited demo. Buy the full access and support our work.

@blokhin blokhin added the bug Something isn't working label Mar 25, 2024
@stan-donarise
Copy link
Collaborator

it is shown by default:

show_demo_warn? true

in $mpds_visavis_app for example, it is disabled :
show_demo_warn false

so we can set the default to false (here: visavis/plot/plot.view.tree) and set it to true only in MPDS embedding

@blokhin blokhin added todo and removed bug Something isn't working labels May 22, 2024
@stan-donarise
Copy link
Collaborator

stan-donarise commented May 30, 2024

@blokhin
Copy link
Member Author

blokhin commented Jul 30, 2024

This logic is very unclear:

const phase_data_demo = this.plot_raw()?.type()! == 'pd' ? this.phase_data_demo() : false
const show_demo_warn = this.show_demo_warn()
&& ! [ 'matrix', 'discovery' ].includes( this.plot_raw()?.type()! )
&& ! phase_data_demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants