Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future units clash when using namespace std; #317

Closed
JohelEGP opened this issue Nov 23, 2021 · 3 comments
Closed

Future units clash when using namespace std; #317

JohelEGP opened this issue Nov 23, 2021 · 3 comments
Labels
refactor Modify existing code potentially causing breaking changes

Comments

@JohelEGP
Copy link
Collaborator

The same issue at ericniebler/range-v3#1271 will happen here, if mp-units hopefully makes it to the Standard. Because the library will be proposed in parts, and not everything will be standardized, so users will have reasons to continue using mp-units.

@mpusz
Copy link
Owner

mpusz commented Nov 24, 2021

I was not aware of this issue but actually, a few days ago I considered changing the namespace (and the include directory name) to mp_units just to clean things up as it may also collide with other potential units libraries installed on the filesystem. I decided to not do it then as it was not much benefit and could break the users we already have.

But your issue sheds new light on this subject. Probably we should consider doing such a change for the next release.

@mpusz mpusz added environment Please improve the development environment refactor Modify existing code potentially causing breaking changes and removed environment Please improve the development environment labels Nov 24, 2021
@mpusz mpusz added this to the v0.8.0 milestone Nov 24, 2021
@mpusz
Copy link
Owner

mpusz commented Sep 9, 2022

@JohelEGP, do you have a suggestion what is the best way to proceed here? I would like to make this change in the new framework, as we are breaking users' code already. Should we just rename the namespace and the includes header directory to mp_units, or maybe should we do something fancier?

@JohelEGP
Copy link
Collaborator Author

JohelEGP commented Sep 9, 2022

Should we just rename the namespace and the includes header directory to mp_units

That's good enough.

@mpusz mpusz modified the milestones: v0.8.0, v0.9.0 (V2 framework) Dec 5, 2022
@mpusz mpusz mentioned this issue Dec 17, 2022
18 tasks
@mpusz mpusz closed this as completed in 2cf736a Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Modify existing code potentially causing breaking changes
Projects
None yet
Development

No branches or pull requests

2 participants