Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving mpv window in a consecutive manner triggers MBTN_LEFT_DBL #13225

Closed
Sneakpeakcss opened this issue Jan 5, 2024 · 1 comment · Fixed by #14251
Closed

Moving mpv window in a consecutive manner triggers MBTN_LEFT_DBL #13225

Sneakpeakcss opened this issue Jan 5, 2024 · 1 comment · Fixed by #14251
Labels

Comments

@Sneakpeakcss
Copy link

Important Information

Provide following Information:

  • mpv version: mpv-x86_64-v3-20240104-git-448cb4d
  • Windows Version: WIN10 22H2
  • Source of the mpv binary: zhongfly
  • If known which version of mpv introduced the problem
  • GPU model, driver and version: RX570 Adrenalin 23.11.1
  • Possible screenshot or video of visual glitches:
mpv.doubleclick.window.drag.mp4

Reproduction steps

  • Drag the window for a short distance, release and drag again.

Expected behavior

Second mouse press that falls under input-doubleclick-time shouldn't trigger after the mpv window was moved.

Actual behavior

Second click triggers MBTN_LEFT_DBL after trying to quickly move window in a consecutive manner.

Log file

mpvlog.txt


In a way this seems like an extension of #13003 (?) @na-na-hi, and is probably the last problematic behaviour when it comes to window dragging issues after #12214, #1921 were fixed.

@na-na-hi
Copy link
Contributor

na-na-hi commented Jan 5, 2024

This issue also exists on X11. From the look at the input handling logic, it should also exist on all other platforms.

This needs to be fixed separately for all platforms to detect whether the window has been moved by dragging, since the input system isn't aware of the global mouse position.

Basically what was said in #7563 (comment) needs to be done, and both this issue and #7563 will be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants