Using a url string with connect() parses full host instead of hostname

[seubert]

I am calling connect() with a URL like so: tcp://username:password@mqtt.redacted.com:1883?clientId=1150293638929, which is, subsequently, calling createClient('1883', 'mqtt.redacted.com:1883', opts). I am thinking this should, instead, be createClient('1883', 'mqtt.redacted.com', opts)?

I am happy to open a PR fixing this, but I'm not sure which is the desired behavior. My case seems to require the second one, which currently doesn't work without a patch.

[mcollina]

Yes it is, thanks! Remember to add a unit test for it!

[mcollina]

Any updates on this? I'd love to have it in 0.3.9.

[seubert]

@mcollina The patch is easy, but I'm having trouble figuring out how to put a useful test in. Mocha doesn't have spies so I can't easily make sure the right things are being passed to createClient and I can't find anywhere that the host is exposed after connect() is called. Ideas?

[mcollina]

Got it, add sinon as a devDepenency and you are done :).

[mcollina]

Any update on this?

[seubert]

Ahhh, so sorry, I will get this in within the next couple hours. Rough weekend personally.