Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading large chat log freezes game when loading world - 211.6.7 #191

Closed
ARedstoneMan opened this issue Jul 30, 2024 · 28 comments
Closed

Loading large chat log freezes game when loading world - 211.6.7 #191

ARedstoneMan opened this issue Jul 30, 2024 · 28 comments
Labels
bug Something isn't working or is broken/crashing performance Causes / fixes lag, lag spikes, or noticable stuttering

Comments

@ARedstoneMan
Copy link

ARedstoneMan commented Jul 30, 2024

Description

Game freezes up when loading into a world or server on "Loading Terrain" screen and forces the user to force quit the game. When chatlog.json is deleted or renamed, game functions as normal (will link problematic chat log below)

How to reproduce

  1. Use given chat log
  2. Load game
  3. Attempt to join any server or world

Expected result

When you attempt to join a world or server, it should load you in without freezing indefinitely. Also, something specific in the chat log should not prevent loading into a world.

Log file link

https://mclo.gs/pFHVqEG (censored sensitive information)

Specs and Details

Required information:

  • Windows 11 Pro
  • 210.6.5.1
  • 0.15.11, 0.100.7+1.21, 3.5.0+1.21 (Fabric, Fabric API, YACL respectively)
  • Mod Menu: 11.0.1

Optional but suggested information:

{
  "time": true,
  "timeDate": "HH:mm:ss",
  "timeFormat": "[$]",
  "timeColor": 16733695,
  "hover": true,
  "hoverDate": "MM/dd/yyyy",
  "hoverFormat": "$",
  "hoverColor": 16777215,
  "counter": true,
  "counterFormat": "\u00268(\u00267x\u0026r$\u00268)",
  "counterColor": 16777045,
  "counterCheckStyle": false,
  "counterCompact": false,
  "counterCompactDistance": 0,
  "boundary": true,
  "boundaryFormat": "\u00268[\u0026r$\u00268]",
  "boundaryColor": 5636095,
  "chatlog": true,
  "chatlogSaveInterval": 0,
  "chatHidePacket": true,
  "chatWidth": 0,
  "chatMaxMessages": 16384,
  "chatNameFormat": "\u003c$\u003e",
  "chatNameColor": 16777215,
  "shiftChat": 10,
  "messageDrafting": false,
  "onlyInvasiveDrafting": false,
  "searchDrafting": true,
  "hideSearchButton": false,
  "vanillaClearing": false,
  "copyColor": 5636095,
  "copyReplyFormat": "/msg $ "
}
  • See attatched file below (e.json) for chatlog
    e.json
@ARedstoneMan ARedstoneMan added the bug Something isn't working or is broken/crashing label Jul 30, 2024
@mrbuilder1961
Copy link
Owner

it seems like chatpatches didn't even load the chatlog completely, so i wonder if it was just taking a really long time to process all the data, although this is a concerning issue. the log shows 35 history messages and 5195 received messages

@mrbuilder1961 mrbuilder1961 changed the title Chat log contents causes game to freeze up when loading world or server - 210.6.5.1 - 1.21 Loading large chat log freezes game when loading world - 210.6.5.1 Aug 4, 2024
@mrbuilder1961
Copy link
Owner

i assume the issue will persist, but could you try loading the chatlog with this dev version and lmk the results?

@ARedstoneMan
Copy link
Author

Issue persists.

@nicko302
Copy link

nicko302 commented Aug 12, 2024

i'm facing this issue too. an obvious fix is to disable the chat log, which does work in preventing the issue but ofc if you want the chat log (which i do) then it isnt a permanent fix.

@ARedstoneMan
Copy link
Author

I may be wrong, but the way I understand it, a potential fix could be to clear old messages in the log after too many have been logged, to keep the file size low.

@mrbuilder1961
Copy link
Owner

I may be wrong, but the way I understand it, a potential fix could be to clear old messages in the log after too many have been logged, to keep the file size low.

the message limit is set by the max message config option. so if you have a large value it will increase the footprint and time to load. that's not to say softlocking the game is intended, however.

@SirPotato42
Copy link

I also have this issue

@mrbuilder1961 mrbuilder1961 added the performance Causes / fixes lag, lag spikes, or noticable stuttering label Aug 23, 2024
@ttrafford7
Copy link

confirm this too

@DrKasango
Copy link

Tried the latest build, the issue persists.
https://mclo.gs/0olfsQv

Btw, tried to reduce the max message config option to 5000, still freezed on loading world.
Sorry for the confusion with the issue #180.

@mrbuilder1961
Copy link
Owner

No worries, thanks for re-uploading it over here. if possible, could you try to load the chat log again and just wait it out until the game either crashes or it loads? Then when you send the log, chat patches will note how long it took and I can use that for future debugging!

@DrKasango
Copy link

Last 10 times or so it was just loading terrain with neither crashing the game or letting me in for more than 10 minutes, while no new lines appeared in the latest.log file, so it ends exactly the same when I manually force the application to close.
I can try again, of course, but I am not sure such a log will be of any help.

@mrbuilder1961
Copy link
Owner

okay i understand, that should be enough on its own. i am wondering is this on every server or just specific ones? and does this happen on single player at all?

additionally if you could upload your chat log file to pastebin or something that would be great and i can try to reproduce your scenario.

@DrKasango
Copy link

The same for other servers and for singleplayer as well.
Singleplayer log:
https://mclo.gs/uiYdjg5
https://pastebin.com/WjxxjgCr

@DrKasango
Copy link

Tried 211.6.7 just in case, issue persists.
https://mclo.gs/KZIZXgt

@mrbuilder1961 mrbuilder1961 changed the title Loading large chat log freezes game when loading world - 210.6.5.1 Loading large chat log freezes game when loading world - 211.6.7 Sep 11, 2024
@RomanPro100
Copy link

Same issue, world loading takes around 2 MINUTES, both when joining Singleplayer and Multiplayer

@mrbuilder1961
Copy link
Owner

has anyone experienced this issue without any other mods installed, minus dependencies?

@DrKasango
Copy link

Here is the log without any other mods installed (except fabric api and kotlin):
https://mclo.gs/3mKirK6

@DrDerp04
Copy link

I also have this issue. are there any fixes for it?

@SirPotato42
Copy link

I also have this issue. are there any fixes for it?

I second this

@mrbuilder1961
Copy link
Owner

mrbuilder1961 commented Sep 14, 2024

@DrKasango
Copy link

Haven't noticed any changes:
https://mclo.gs/Bfe2EEr

@DrKasango
Copy link

Seems to be fixed, thanks a lot!

@RomanPro100
Copy link

Seems to be fixed for me too, still a tiny bit (0.5-1s) slower than without the mod

@mrbuilder1961 mrbuilder1961 added the unpublished Fixed in a bleeding edge commit build, full release not published yet label Sep 15, 2024
@SirPotato42
Copy link

@mrbuilder1961
Copy link
Owner

try the build here, should be minutely faster https://github.com/mrbuilder1961/ChatPatches/actions/runs/10875600736

@DrDerp04
Copy link

Im having no problems with that build, thank you <3

@mrbuilder1961
Copy link
Owner

fixed in 211.6.8!

@mrbuilder1961 mrbuilder1961 removed the unpublished Fixed in a bleeding edge commit build, full release not published yet label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or is broken/crashing performance Causes / fixes lag, lag spikes, or noticable stuttering
Projects
None yet
Development

No branches or pull requests

8 participants