Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intervention/httpauth has a new version to make Laravel 7 work #664

Closed
edalzell opened this issue Mar 3, 2020 · 5 comments · Fixed by #667
Closed

intervention/httpauth has a new version to make Laravel 7 work #664

edalzell opened this issue Mar 3, 2020 · 5 comments · Fixed by #667

Comments

@edalzell
Copy link

edalzell commented Mar 3, 2020

Any chance you can update?

I'll take a look at a PR in a bit.

@edalzell
Copy link
Author

edalzell commented Mar 3, 2020

I can't get the tests to run because I'm on PHP 7.4, I'll roll back to 7.3 to see if we can move this forward a bit.

@Stolz
Copy link

Stolz commented Mar 19, 2020

I'm also looking forward this. I'm the maintainer of Stolz/Assets, a package somehow popular among Laravel users. The package itself does work fine with Laravel 7 but it cannot be installed because it depends on current version of mrclay/minify, which in turn depends on intervention/httpauth:2.0 which is not compatible with Laravel 7. The author of intervention/httpauth has made it compatible with Laravel 7 in recent 3.x versions

@glensc
Copy link
Collaborator

glensc commented Mar 19, 2020

I'm happy to review pull request

@edalzell edalzell mentioned this issue Mar 19, 2020
@edalzell
Copy link
Author

@glensc see #666 . I needed to change the test files to bring PHPUnit more current then change the test classes to make the method signatures properly match. I also remove the php5.3 restriction as that's quite old.

@glensc glensc linked a pull request Mar 24, 2020 that will close this issue
@edalzell
Copy link
Author

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants