Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude SSI Comments #671

Closed
khalwat opened this issue Mar 31, 2020 · 0 comments · Fixed by #670
Closed

Exclude SSI Comments #671

khalwat opened this issue Mar 31, 2020 · 0 comments · Fixed by #670

Comments

@khalwat
Copy link
Contributor

khalwat commented Mar 31, 2020

Exclude Nginx & Apache Server Side Include (SSI) comments from being stripped via minification, the same way IE directives are not stripped.

Both Nginx & Apache SSI directives begin with:

<!--#

So we can just look for the # and don’t strip the comment in that case.

Nginx SSI: http://nginx.org/en/docs/http/ngx_http_ssi_module.html

Apache SSI: https://httpd.apache.org/docs/2.4/howto/ssi.html

Implemented via PR: #670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude SSI Comments from HTML minify nystudio107/minify-lib
1 participant
@khalwat