Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support File History UI #118

Closed
hdpoliveira opened this issue Jul 3, 2020 · 5 comments
Closed

Support File History UI #118

hdpoliveira opened this issue Jul 3, 2020 · 5 comments

Comments

@hdpoliveira
Copy link
Collaborator

hdpoliveira commented Jul 3, 2020

Something similar to what GitLens does: https://www.youtube.com/watch?v=bRdQw4-sGIY

We already have a File History command, so this issue is about supporting a GUI

@hdpoliveira hdpoliveira changed the title Support File History Support File History UI Jul 5, 2020
@incidentist
Copy link
Collaborator

How do you feel about the GUI for this being the Timeline view (#77) instead of being driven by the command palette?

@hdpoliveira
Copy link
Collaborator Author

hdpoliveira commented Jul 5, 2020

I think you are right. The timeline view is better than a custom GUI.

Are you working on #77?

@mrcrowl
Copy link
Owner

mrcrowl commented Jul 5, 2020

Makes sense to me to use timeline. Command palette always felt like a hack.

@hdpoliveira
Copy link
Collaborator Author

Closing in favor of #77

@incidentist
Copy link
Collaborator

Are you working on #77?

I started on it awhile back, but moved on to other stuff because it's not clear to me if we can ship an extension that uses the Timeline API since it isn't finalized yet. If you want to take it, go for it. I did maybe 20 minutes of work that probably isn't worth reviving since the repo has changed so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants