Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEEKING A NEW MAINTAINER / OWNER FOR HG EXTENSION #71

Closed
mrcrowl opened this issue Apr 26, 2019 · 22 comments
Closed

SEEKING A NEW MAINTAINER / OWNER FOR HG EXTENSION #71

mrcrowl opened this issue Apr 26, 2019 · 22 comments

Comments

@mrcrowl
Copy link
Owner

mrcrowl commented Apr 26, 2019

Hi users,

Sorry I haven't been very active in supporting hg in the past while.

This extension was created when my team and I were using hg heavily for work. We are in the process of moving entirely to git.

If there is anyone with typescript / javascript experience that would like to continue with maintenance and development of the extension (or fork it and start a new extension) I will provide full support including transfer/ownership of this repo. We can speak with vs code team about whether it is possible to also transfer ownership of the published extension too, or alternatively I can be involved with publishing only.

Please reach out if this sounds like something you would like to do.

@grinapo
Copy link

grinapo commented Apr 26, 2019

This one showed up in the extension browser:
https://github.com/KristjanTammekivi/vscode-hg

And a good bunch of forks:
https://github.com/mrcrowl/vscode-hg/network/members

@mrcrowl
Copy link
Owner Author

mrcrowl commented Apr 26, 2019 via email

@nsgundy
Copy link

nsgundy commented Jun 11, 2019

Hmm, interested in keeping this extension alive. Just not sure if reality lets me spend enough time on it to put a dent into the current backlog. Might have to give it a try for some time to see if its realistic?

@mrcrowl
Copy link
Owner Author

mrcrowl commented Jun 11, 2019

Hey @nsgundy, thanks for the interest! Is there something that you'd like to see done from the backlog? I don't think there's an expectation that you have to do everything on the issues list, although bugs are probably a good place to start.

Did you want to pick something and start with a PR?

@nsgundy
Copy link

nsgundy commented Jun 12, 2019

@mrcrowl Well, yes, bugs mainly.

Starting with a PR is probably a good idea. I would pick #35.

@nsgundy
Copy link

nsgundy commented Jul 25, 2019

Um, well, as you can see, I haven't even started on anything yet.

@incidentist
Copy link
Collaborator

I've got time and could take this over. Just submitted a (simple) PR for a bad bug, which got me familiar with the code. Seems like I could start with the existing PRs and see if others have done anything on forks that could be pulled in.

@incidentist
Copy link
Collaborator

Hmm. I submitted another PR for a small bug but realized my first PR was on the master branch of my fork. I can redo them but if I could take over the extension, I'd probably just merge them as-is. I am also working on #30 .

@mrcrowl
Copy link
Owner Author

mrcrowl commented May 24, 2020

Thanks @incidentist, this would be amazing. Let's work together on getting your PRs merged and then we can sort out access to the repro and publishing rights for vscode marketplace. I hope to look at these PRs later today.

@incidentist
Copy link
Collaborator

@mrcrowl Great! Just pushed an implementation of #30 . Let me know what you want to do about repo access. I'm fine working on this one for now until/if the VSCode admins can switch over to mine.

@incidentist
Copy link
Collaborator

@mrcrowl I created a couple more small PRs for bugs. Let me know if/when you want to move forward with changing ownership or co-ownership or whatever. 🚀

@hdpoliveira
Copy link
Collaborator

hdpoliveira commented Jun 14, 2020

Hi! I'm interested in this!
However I don't know anything about Typescript or VSCode extensions, but I'm eager to learn 😃

@mrcrowl @incidentist do you recommend a first issue? Or some documentation?

@incidentist
Copy link
Collaborator

@hdpoliveira Great! I've only recently started working on this, and I think I took most of the easy bugs, but let's see...
#37 might be a simple fix.
#60 would be a good one if you're on Windows.

I found TypeScript very easy to pick up. The VSCode API is harder because there's a lot of it. If you want to try any of those bugs, we could hop on a video call sometime and poke at it together.

@incidentist
Copy link
Collaborator

Questions for the room:
@hdpoliveira Do you want to be a co-maintainer of this project? You seem enthusiastic and very knowledgable about Mercurial, and I'm grateful to have someone to bounce ideas and code off of. 🍻
@mrcrowl How do you feel about making @hdpoliveira a co-maintainer, if he's into it? Also, you're currently the only person who can package and manage releases. Are you okay continuing that?
@hdpoliveira @mrcrowl Now that I've merged shelve/unshelve stuff, my thought would be to release 1.6.0 after we merge PRs #91 and #88 . Does that sound good?
@hdpoliveira What do you want to work on next? I think #59 is high-impact but it's not sexy. I also want to work on #77 and #95.

🚀

@hdpoliveira
Copy link
Collaborator

@hdpoliveira Do you want to be a co-maintainer of this project? You seem enthusiastic and very knowledgable about Mercurial, and I'm grateful to have someone to bounce ideas and code off of. 🍻

Yes, I'd like that very much!

@hdpoliveira @mrcrowl Now that I've merged shelve/unshelve stuff, my thought would be to release 1.6.0 after we merge PRs #91 and #88 . Does that sound good?

To me it does. Since #88 does not affect users, it could be left out of the version.

@hdpoliveira What do you want to work on next? I think #59 is high-impact but it's not sexy. I also want to work on #77 and #95.

#59 I had trouble reproducing. If you can tell me how to reproduce I can work on it.
#95 is something we definitely need. @mrcrowl I noticed some PowerShell scripts in the tests repository, could you please explain us their purpose/how to use them?
I didn't open an issue for it, but I think we should implement automatic code formating and linting.
I want to work on #100 and #99.

@mrcrowl
Copy link
Owner Author

mrcrowl commented Jun 26, 2020

Yup, I’m happy to continue doing releases. I could carry out some testing for you beforehand. Give me a nudge when it’s ready.

The only two things required to be release-ready are:

  • Updating package.json version
  • Updating CHANGELOG.md

I package to a vsix file as well as publishing to marketplace. The vsix gets attached to the release in GitHub. This provides a manual rollback mechanisms for users if something gets broken by the release.

@mrcrowl
Copy link
Owner Author

mrcrowl commented Jun 26, 2020

And just wanted to say a big thanks to both of you. Pleased to see this project being continued.

@mrcrowl
Copy link
Owner Author

mrcrowl commented Jun 26, 2020

I noticed some PowerShell scripts in the tests repository, could you please explain us their purpose/how to use them?

The purpose of these was to try and validate that hg responses, which the extension relies on, remain consistent over time. They are largely incomplete though and were only manual “eyeball” tests.

There is potential to automate, with some effort. I would probably do away with the powershell though and just use node.

The concept was to use a second local folder to represent the remote repository.

@hdpoliveira
Copy link
Collaborator

@incidentist I'm filing issues left and right here 😄
The ones I'm working on I'm putting myself as the assignee.
Feel free to pick any issue you'd like!

@hdpoliveira
Copy link
Collaborator

@mrcrowl I think we're ready for version 1.7.0 🥳 🎉

@mrcrowl
Copy link
Owner Author

mrcrowl commented Aug 3, 2020

v1.7.0 released and published to vscode marketplace

@mrcrowl
Copy link
Owner Author

mrcrowl commented Aug 3, 2020

Great work gents :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants