Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmdloader can't load single pose properly #23287

Closed
Xposeder opened this issue Jan 20, 2022 · 6 comments
Closed

mmdloader can't load single pose properly #23287

Xposeder opened this issue Jan 20, 2022 · 6 comments
Assignees

Comments

@Xposeder
Copy link

Xposeder commented Jan 20, 2022

Describe the bug

mmdloader can't load single pose properly

To Reproduce

Steps to reproduce the behavior:

  1. Go to this example
  2. change the pose to any
  3. nothing happened, that's the problem

Live example

webgl_loader_mmd_pose
Expected behavior

load pose properly ,like 0.130 version

Screenshots

Platform:

  • Device: Desktop
  • OS: Windows
  • Browser: Chrome97
  • Three.js version: [r136]
@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 20, 2022

It seems it works up to r133:

https://raw.githack.com/mrdoob/three.js/r133/examples/webgl_loader_mmd_pose.html

With r134, the pose can't be changed anymore.

https://raw.githack.com/mrdoob/three.js/r134/examples/webgl_loader_mmd_pose.html

@takahirox
Copy link
Collaborator

takahirox commented Jan 21, 2022

Probably this one #22510 (comment)

Update: I'm not sure if the above link to a resolved conversation works so let me put the screenshot of my comment.

image

VPD (MMD pose data file) is often encoded as Shift_JIS charcode and it seems we need some tricks to load Shift_JIS encoded data correctly.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 21, 2022

Reverting the usage of fetch() in FileLoader actually solves the issue.

/ping @gkjohnson @DefinitelyMaybe

@ycw
Copy link
Contributor

ycw commented Jan 21, 2022

preview
https://raw.githack.com/ycw/three.js/fileloader-encoding-preview/examples/webgl_loader_mmd_pose.html

@Xposeder
Copy link
Author

Thank you for your willingness to solve this problem!

@DefinitelyMaybe
Copy link
Contributor

I'm glad this was found and I'm sorry as I didn't know about this case beforehand.

@Mugen87 Mugen87 added Regression and removed Addons labels Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants