You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Per the discussion in #25057 and the implementation in #25440, IFCLoader was removed from addons. The editor still dynamically imports it from jsm/examples/loaders, where it obviously no longer exists, meaning the editor fails to load IFC models. (Link to editor import of IFCLoader.js)
I tried starting a PR to update the import maps for the editor as per the changes to the IFC example in #25440, which results in imports working on the first page reload after clearing my cache, but seems to result in a number of failed requests for web-ifc-mt.worker.js when trying to import after a second reload. I think this is potentially related to editor/sw.js, but I can't quite pin it down (sorry).
I imagine it'd be equally valid to remove IFC support from the editor, as it doesn't make use of any other external loaders, but this might be a bit of a shame.
Apologies for this slightly off-topic aside:
I found getting to the bottom of this was a bit difficult, I think due to the deprecation of web-ifc-three mentioned in #27467. This means that most of the documentation links on https://github.com/ThatOpen/web-ifc-three are 404s at the moment, so trying to dig into where this request for web-ifc-mt.worker.js originated from, and whether there was a way to avoid it, was a bit more challenging than it might've been. Is there still a plan to migrate the example (and potentially the editor) to https://github.com/ThatOpen/engine_components? I think it's a bit of a challenge to make use of the current example code given the temporarily missing docs.
I imagine it'd be equally valid to remove IFC support from the editor, as it doesn't make use of any other external loaders, but this might be a bit of a shame.
As a first step, I suggest to remove the IFC related code in Loader.js that doesn't work right now. Would be interested in filing a PR for that?
Since web-ifc-three is deprecated, the webgl_loader_ifc example needs a different approach at some point in order to import IFC assets.
@agviegas I'm not sure about the current state but does Open BIM Components provide an easy way for devs to import IFC files into a three.js app? Is there a loader class users can import?
Regarding the roadmap, webgl_loader_ifc should be migrated to the new IFC repository Open BIM Components. When we see how this is done, we can restore IFC support in the editor.
After reconsideration it's better if the editor only supports loaders which are located in the three repository and not external ones. That makes it easier to avoid interoperability and hosting issues.
Description
Per the discussion in #25057 and the implementation in #25440,
IFCLoader
was removed from addons. The editor still dynamically imports it fromjsm/examples/loaders
, where it obviously no longer exists, meaning the editor fails to load IFC models. (Link to editor import ofIFCLoader.js
)I tried starting a PR to update the import maps for the editor as per the changes to the IFC example in #25440, which results in imports working on the first page reload after clearing my cache, but seems to result in a number of failed requests for
web-ifc-mt.worker.js
when trying to import after a second reload. I think this is potentially related toeditor/sw.js
, but I can't quite pin it down (sorry).I imagine it'd be equally valid to remove IFC support from the editor, as it doesn't make use of any other external loaders, but this might be a bit of a shame.
Apologies for this slightly off-topic aside:
I found getting to the bottom of this was a bit difficult, I think due to the deprecation of
web-ifc-three
mentioned in #27467. This means that most of the documentation links on https://github.com/ThatOpen/web-ifc-three are 404s at the moment, so trying to dig into where this request forweb-ifc-mt.worker.js
originated from, and whether there was a way to avoid it, was a bit more challenging than it might've been. Is there still a plan to migrate the example (and potentially the editor) to https://github.com/ThatOpen/engine_components? I think it's a bit of a challenge to make use of the current example code given the temporarily missing docs.Reproduction steps
The text was updated successfully, but these errors were encountered: