-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make loaders' load() to return stuff. #8091
Comments
Returning the request sounds good to me. |
My original idea stems from, as you guessed it, the need to abort loading. But if the model is multi-part (such as geometry + textures) it might not be enough (or too late) to abort XMLHttpRequest. Maybe there is better way to address this? Maybe via THREE.LoadingManager? It does not manage much now beyond tracking loading progress. |
You may find this PR interesting. #9600 |
closing in favor of #9600 if it does what it says
|
For example, if XHRLoader's load() returns XMLHttpRequest, but VRMLLoader's load() does not return it (swallows it), so there is no easy way to call .abort() on underlying XMLHttpRequest, for example.
Same goes for OBJLoader, ColladaLoader(1 and 2), STLLoader, I am bored to check more loader, etc
The text was updated successfully, but these errors were encountered: