Cameras: Convert to es6 class. #19989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm afraid this PR breaks |
Yes, thank you to review, I try to solve it. |
Closed
43 tasks
Mugen87
reviewed
Aug 17, 2020
| @@ -13,205 +13,205 @@ import { | |||
| import { BokehShader } from "../shaders/BokehShader2.js"; | |||
| import { BokehDepthShader } from "../shaders/BokehShader2.js"; | |||
|
|
|||
| var CinematicCamera = function ( fov, aspect, near, far ) { | |||
| class CinematicCamera extends PerspectiveCamera { | |||
There was a problem hiding this comment.
This PR is not mergeable as long as you have to modify example code.
Notice that it is not acceptable to just modify jsm modules. Until end of this year, example/js and exampes/jsm have to stay in sync (expect for new files).
Please revert any changes to CinematicCamera, PerspectiveCamera and Camera.
There was a problem hiding this comment.
How about this #20102
There was a problem hiding this comment.
Closing in favor of #20102.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.