Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Covert to es6 class. #20008

Closed
wants to merge 4 commits into from
Closed

core: Covert to es6 class. #20008

wants to merge 4 commits into from

Conversation

linbingquan
Copy link
Contributor

Part of core folder, passed E2E testing. Please to review.

@DefinitelyMaybe DefinitelyMaybe mentioned this pull request Aug 4, 2020
Closed
43 tasks
@linbingquan
Copy link
Contributor Author

Clean up for #19986 (comment)

marcofugaro
marcofugaro reviewed Aug 18, 2020
View reviewed changes
src/core/Geometry.js Outdated Show resolved Hide resolved
@mrdoob mrdoob added this to the r121 milestone Aug 23, 2020
@mrdoob mrdoob modified the milestones: r121, r122 Sep 29, 2020
@mrdoob mrdoob modified the milestones: r122, r123 Oct 28, 2020
@mrdoob mrdoob modified the milestones: r123, r124 Nov 25, 2020
@mrdoob mrdoob modified the milestones: r124, r125 Dec 24, 2020
@mrdoob mrdoob modified the milestones: r125, r126 Jan 27, 2021
@DefinitelyMaybe
Copy link
Contributor

DefinitelyMaybe commented Feb 9, 2021 •
edited
Loading

@linbingquan and these conflicts too, pleeeeease 🙏

edit: oh, also keeping it to just src/ too. there's a couple of example script changes lurking in there

@linbingquan linbingquan force-pushed the dev-es6-core branch 2 times, most recently from 3f9cd83 to aeb890c Compare February 12, 2021 11:06
linbingquan
linbingquan commented Feb 12, 2021
View reviewed changes
examples/jsm/deprecated/Geometry.js Outdated Show resolved Hide resolved
src/core/InterleavedBuffer.js Outdated Show resolved Hide resolved
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 12, 2021

You can't convert any files in the examples/jsm directory if counterparts exist in examples/js.

Please undo all changes to examples/jsm.

@linbingquan
Copy link
Contributor Author

You can't convert any files in the examples/jsm directory if counterparts exist in examples/js.

Please undo all changes to examples/jsm.

Thank you for your reply, OK, I got it.

Mugen87
Mugen87 reviewed Feb 12, 2021
View reviewed changes
src/core/Raycaster.js Outdated Show resolved Hide resolved
linbingquan
linbingquan commented Feb 12, 2021
View reviewed changes
src/core/Raycaster.js Outdated Show resolved Hide resolved
src/core/BufferAttribute.js Outdated Show resolved Hide resolved
src/core/InstancedBufferAttribute.js Outdated Show resolved Hide resolved
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 17, 2021

You can't convert InstancedBufferGeometry in this PR since LineSegmentsGeometry is derived from it.

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 17, 2021

EventDispatcher is also converted in this PR: #20943

@mrdoob Should we close #20943 or undo the changes to EventDispatcher in this PR?

@mrdoob mrdoob modified the milestones: r126, r127 Feb 23, 2021
@Mugen87 Mugen87 mentioned this pull request Mar 4, 2021
Merged
@mrdoob mrdoob modified the milestones: r127, r128 Mar 30, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 13, 2021

Closing in favor of #21646.

Thanks for the PR though!

@Mugen87 Mugen87 closed this Apr 13, 2021
@Mugen87 Mugen87 removed this from the r128 milestone Apr 13, 2021
@linbingquan linbingquan deleted the dev-es6-core branch February 13, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 left review comments

@marcofugaro marcofugaro marcofugaro left review comments

@yomotsu yomotsu yomotsu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@linbingquan @DefinitelyMaybe @Mugen87 @yomotsu @marcofugaro @mrdoob