Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebXR: Covert to es6 class. #20038

Closed
wants to merge 2 commits into from
Closed

WebXR: Covert to es6 class. #20038

wants to merge 2 commits into from

Conversation

linbingquan
Copy link
Contributor

No description provided.

@linbingquan linbingquan mentioned this pull request Aug 7, 2020
Closed
43 tasks
@mrdoob mrdoob added this to the r121 milestone Aug 23, 2020
@mrdoob mrdoob modified the milestones: r121, r122 Sep 29, 2020
@mrdoob mrdoob modified the milestones: r122, r123 Oct 28, 2020
@mrdoob mrdoob modified the milestones: r123, r124 Nov 25, 2020
@mrdoob mrdoob modified the milestones: r124, r125 Dec 24, 2020
@mrdoob mrdoob modified the milestones: r125, r126 Jan 27, 2021
@DefinitelyMaybe
Copy link
Contributor

DefinitelyMaybe commented Feb 19, 2021 •
edited
Loading

@linbingquan checking in on this PR.

A conflict to resolve.

I light of mrdoobs comments here, are there any any additional changes you'd make?

@mrdoob mrdoob modified the milestones: r126, r127 Feb 23, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 16, 2021

Do you mind resolving the merge conflicts?

@DefinitelyMaybe
Copy link
Contributor

👍

@mrdoob mrdoob modified the milestones: r127, r128 Mar 30, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 14, 2021

Closing in favor of #21646 and #21648.

@linbingquan I'll still add you to the release notes for these changes 👍 .

@Mugen87 Mugen87 closed this Apr 14, 2021
@Mugen87 Mugen87 removed this from the r128 milestone Apr 14, 2021
@linbingquan linbingquan deleted the dev-es6-webxr branch February 13, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linbingquan @DefinitelyMaybe @Mugen87 @mrdoob