Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLProgram: Refactor GLSL conversion. #20090

Merged
merged 1 commit into from
Aug 16, 2020
Merged

WebGLProgram: Refactor GLSL conversion. #20090

merged 1 commit into from
Aug 16, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 16, 2020

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Aug 16, 2020

Let me check the result of the E2E tests...

@mrdoob mrdoob added this to the r120 milestone Aug 16, 2020
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Aug 16, 2020 •
edited
Loading

Okay, this looks good now! (one if statement was unnecessary)

@mrdoob mrdoob merged commit 5c7ab46 into mrdoob:dev Aug 16, 2020
@mrdoob
Copy link
Owner

mrdoob commented Aug 16, 2020

Thanks!

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Aug 17, 2020

Updated the migration guide to explain the ShaderMaterial.glslVersion property:

https://github.com/mrdoob/three.js/wiki/Migration-Guide#r119--r120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r120
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob