Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finishing Manual::getting started - Arabic documentation #20098

Merged
merged 4 commits into from
Aug 17, 2020

Conversation

hassanMuhamad
Copy link
Contributor

included pages:

  • FAQ page
  • Useful links page

updates:

  • list mapping

@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 17, 2020

Sidenote: Documentation pages which are not yet translated to arabic produce an ugly 404 page. Wouldn't it make sense to define the entire doc pages in the ar section and just point to the English counterparts if no translation is available? I think the project does the same in context of the Chinese translation by just copy over all pages to the zh directory.

@mrdoob
Copy link
Owner

mrdoob commented Aug 17, 2020

I think I would make the ugly 404 nicer instead. Not sure if it's possible... 🤔

@mrdoob mrdoob added this to the r120 milestone Aug 17, 2020
@mrdoob mrdoob merged commit 7a879a0 into mrdoob:dev Aug 17, 2020
@mrdoob
Copy link
Owner

mrdoob commented Aug 17, 2020

Thanks!

@hassanMuhamad
Copy link
Contributor Author

It would be nicer if the 404 page shows a message indicating that the page is not translated to the selected language at the current time, information about the requested resource are available in the English version of the documentation. ↩️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants