Line2: Convert Line2 example scripts to ES6 Classes #21495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIK, we do not convert code to ES6 classes in |
|
Makes sense -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #19986
Description
Converts the
examples/js/line/files to use ES6 classes. Once the js files are removed (or built from the jsm files) the iife function definitions can be removed. Tested by running the following examples:https://raw.githack.com/gkjohnson/three.js/line2-class/examples/webgl_lines_fat.html
https://raw.githack.com/gkjohnson/three.js/line2-class/examples/webgl_lines_fat_wireframe.html
And locally modifying the first to ensure raycasting returned hits only when hovering on the line
cc @WestLangley @DefinitelyMaybe