Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add Lut3DNode. #28779

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Node: Add Lut3DNode. #28779

merged 2 commits into from
Jul 1, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 1, 2024

Related issue: -

Description

This PR adds Lut3DNode so we can use 3D LUTs with WebGPURenderer.

Copy link

github-actions bot commented Jul 1, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
682.2 kB (169 kB) 682.2 kB (169 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
459.4 kB (110.9 kB) 459.4 kB (110.9 kB) +0 B

@Mugen87 Mugen87 added this to the r167 milestone Jul 1, 2024
@@ -124,6 +124,7 @@ const exceptionList = [

// WebGPURenderer: Unknown problem
'webgpu_postprocessing_afterimage',
'webgpu_postprocessing_3dlut',
Copy link
Collaborator

@sunag sunag Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I added the previous builds was because it was failing in e2e. So exceptions would not be necessary. One way to solve this would be to split the PR between API and examples, I'm not sure if puppeteer did the builds at test time in three.module.js? If yes, I think that it could be done in three.webgpu.js too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if puppeteer did the builds at test time in three.module.js?

The CI executes a build here before running the E2E tests:

run: npm run build-module

But it seems the command only updates three.module.js.

Copy link
Collaborator

@sunag sunag Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add it rollup.config.js?

export default ( args ) => args.configOnlyModule ? [ builds[ 0 ], builds[ 3 ] ] : builds;

export default ( args ) => args.configOnlyModule ? builds[ 0 ] : builds;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants