-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node: Add Lut3DNode
.
#28779
Node: Add Lut3DNode
.
#28779
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
@@ -124,6 +124,7 @@ const exceptionList = [ | |||
|
|||
// WebGPURenderer: Unknown problem | |||
'webgpu_postprocessing_afterimage', | |||
'webgpu_postprocessing_3dlut', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I added the previous builds was because it was failing in e2e. So exceptions would not be necessary. One way to solve this would be to split the PR between API and examples, I'm not sure if puppeteer did the builds at test time in three.module.js
? If yes, I think that it could be done in three.webgpu.js
too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if puppeteer did the builds at test time in three.module.js?
The CI executes a build here before running the E2E tests:
three.js/.github/workflows/ci.yml
Line 87 in 1e4f2b1
run: npm run build-module |
But it seems the command only updates three.module.js
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could add it rollup.config.js
?
export default ( args ) => args.configOnlyModule ? [ builds[ 0 ], builds[ 3 ] ] : builds;
three.js/utils/build/rollup.config.js
Line 133 in 1e4f2b1
export default ( args ) => args.configOnlyModule ? builds[ 0 ] : builds; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
Related issue: -
Description
This PR adds
Lut3DNode
so we can use 3D LUTs withWebGPURenderer
.