Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Add Missing Export NodeAccess #29993

Merged

Conversation

RenaudRohlinger
Copy link
Collaborator

Related issue: #29881

Description
Missing export was breaking the example webgpu_compute_texture_pingpong.html.

This contribution is funded by Utsubo

@RenaudRohlinger RenaudRohlinger added this to the r171 milestone Nov 29, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.14
78.99
339.14
78.99
+0 B
+0 B
WebGPU 484.61
134.47
484.61
134.47
+0 B
+0 B
WebGPU Nodes 484.08
134.37
484.08
134.37
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.62
111.98
464.62
111.98
+0 B
+0 B
WebGPU 553.37
149.76
553.37
149.76
+0 B
+0 B
WebGPU Nodes 509.25
139.47
509.25
139.47
+0 B
+0 B

@sunag sunag merged commit 4f3e462 into mrdoob:dev Nov 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants