{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":600496149,"defaultBranch":"main","name":"aws-cdk","ownerLogin":"mrlikl","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-02-11T17:13:42.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/110023377?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1721858455.0","currentOid":""},"activityList":{"items":[{"before":"ca7afbbbda7037b006967b8398e3e2d0b450d16f","after":"0c9a5b7fe22fcb31c0742a3a76773e365ece4579","ref":"refs/heads/s3-deploy","pushedAt":"2024-09-16T04:54:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"add snapshot 6","shortMessageHtmlLink":"add snapshot 6"}},{"before":"40559e0b02e0103a37e1bbd1a626229015fdbb84","after":"ca7afbbbda7037b006967b8398e3e2d0b450d16f","ref":"refs/heads/s3-deploy","pushedAt":"2024-09-16T04:53:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"add snapshot 4","shortMessageHtmlLink":"add snapshot 4"}},{"before":"036f0b08d831af89c040195f47fae9c265659578","after":"40559e0b02e0103a37e1bbd1a626229015fdbb84","ref":"refs/heads/s3-deploy","pushedAt":"2024-09-16T04:49:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"add snapshot 3","shortMessageHtmlLink":"add snapshot 3"}},{"before":"ed613094dd2edf15e1c04be2fd16236c4eb8de8f","after":"036f0b08d831af89c040195f47fae9c265659578","ref":"refs/heads/s3-deploy","pushedAt":"2024-09-16T04:48:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"add snapshot 2","shortMessageHtmlLink":"add snapshot 2"}},{"before":"e610d056ec55db0f47d2eb09fff86c25806a0898","after":"ed613094dd2edf15e1c04be2fd16236c4eb8de8f","ref":"refs/heads/s3-deploy","pushedAt":"2024-09-16T04:48:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"add snapshot q","shortMessageHtmlLink":"add snapshot q"}},{"before":"1299bc8f357e18f5e724eee3e298b0cc66e75013","after":"e610d056ec55db0f47d2eb09fff86c25806a0898","ref":"refs/heads/s3-deploy","pushedAt":"2024-09-16T04:31:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"add integ test to test too many sources","shortMessageHtmlLink":"add integ test to test too many sources"}},{"before":"29f7f4135ef2dc0d01cfc5381a80ff79fa1f10d1","after":"1299bc8f357e18f5e724eee3e298b0cc66e75013","ref":"refs/heads/s3-deploy","pushedAt":"2024-09-15T02:45:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"update readme","shortMessageHtmlLink":"update readme"}},{"before":"17fa596e32d0cc48bc208b5c15248eff109bb84d","after":"29f7f4135ef2dc0d01cfc5381a80ff79fa1f10d1","ref":"refs/heads/s3-deploy","pushedAt":"2024-09-15T01:06:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"fix failing integ test","shortMessageHtmlLink":"fix failing integ test"}},{"before":"d2e10947e3ed8df008f5d94403d3fab9c32f5c28","after":"17fa596e32d0cc48bc208b5c15248eff109bb84d","ref":"refs/heads/s3-deploy","pushedAt":"2024-09-15T01:01:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"fix failing integ test","shortMessageHtmlLink":"fix failing integ test"}},{"before":"7c4f423bf14af996203b090429b8c59bd32f50d8","after":"1726abddbe10a22c092de7bf0b566710d13f5efd","ref":"refs/heads/main","pushedAt":"2024-09-14T12:14:24.000Z","pushType":"push","commitsCount":187,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"fix(lambda): invalid Version object created from Version.fromVersionArn (#31433)\n\n### Issue # (if applicable)\n\nCloses https://github.com/aws/aws-cdk/issues/29813\n\n### Reason for this change\n\nThe current `lambda.Version.fromVersionArn` will incorrectly create the lambda function arn with the version qualifier. This is incorrect behaviour and cause CFN deployment failures.\n\n### Description of changes\n\nIf the version arn is an unresolved token, use intrinsics to join the first 7 components. Otherwise, split the array and join the first 7 components directly.\n\n### Description of how you validated changes\n\nAll new and existing tests should pass. New integration tests added with assertions.\n\n### Checklist\n- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"fix(lambda): invalid Version object created from Version.fromVersionA…"}},{"before":"fae5718dd3c281dd4805230c9b61765b33f7a047","after":"d2e10947e3ed8df008f5d94403d3fab9c32f5c28","ref":"refs/heads/s3-deploy","pushedAt":"2024-09-14T11:41:04.000Z","pushType":"push","commitsCount":239,"pusher":{"login":"moelasmar","name":"Mohamed Elasmar","path":"/moelasmar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/71043312?s=80&v=4"},"commit":{"message":"re-run integration testing after resolving the conflicts","shortMessageHtmlLink":"re-run integration testing after resolving the conflicts"}},{"before":"1e7c690f5ec404d7c620dc54692999fee67b3eaf","after":"7c4f423bf14af996203b090429b8c59bd32f50d8","ref":"refs/heads/main","pushedAt":"2024-08-10T05:57:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"feat(elasticloadbalancingv2): connection logs for ALB (#30599)\n\n### Reason for this change\nALB can output connection logs as well as access logs to the S3 bucket, but this is not yet supported by L2 Construct.\nhttps://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-connection-logs.html\n\n### Description of changes\nThe implementation is almost the same as for access logs.\nHowever, since connection logs are not supported by NLB, but only by ALB, the `logConnectionLogs` method is added to the `ApplicationLoadBalancer` instead of the `BaseLoadBalancer`.\n\nThe needed BucketPolicy is described in the documentation only as follows, but to support buckets that still use the ACL, it is necessary to set the same policy that is currently set in the access logs.\n```json\n{\n \"Version\": \"2012-10-17\",\n \"Statement\": [\n {\n \"Effect\": \"Allow\",\n \"Principal\": {\n \"AWS\": \"arn:aws:iam::elb-account-id:root\"\n },\n \"Action\": \"s3:PutObject\",\n \"Resource\": \"arn:aws:s3:::bucket-name/prefix/AWSLogs/aws-account-id/*\"\n }\n ]\n}\n```\nhttps://docs.aws.amazon.com/elasticloadbalancing/latest/application/enable-connection-logging.html#attach-bucket-policy-connection\n\n### Description of how you validated changes\nadd unit tests and integ tests.\n\n\n### Checklist\n- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"feat(elasticloadbalancingv2): connection logs for ALB (aws#30599)"}},{"before":"84dd06b07d112db43119be3cbffe66b898092b33","after":"1e7c690f5ec404d7c620dc54692999fee67b3eaf","ref":"refs/heads/main","pushedAt":"2024-08-09T14:33:12.000Z","pushType":"push","commitsCount":49,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"fix(ec2): prevent deduplication of init command args (#30821)\n\n### Issue # (if applicable)\n\nCloses #26221 \n\n### Reason for this change\n\nPreviously, using `ec2.InitCommand.argvCommand()` would remove some duplicate strings in the input array. This produces an incorrect command in the template, leading to unexpected behaviour.\n\n### Description of changes\n\nAn additional line was added to the `deepMerge` function that is called in the `InitConfig.bindForType()` method, which checks the key of the input array, preventing it from becoming a set (removing duplicates) if it is a list of commands.\n\n### Description of how you validated changes\n\nA unit test was added to generate an `AWS::CloudFormation::Init` resource identical to the one reproduced in the issue. The test was run and failed before the changes were made, and following the changes in `cfn-init.ts`, the test passed.\n\n### Checklist\n- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"fix(ec2): prevent deduplication of init command args (aws#30821)"}},{"before":"b275cc14fc48d08f3a846a7cdb5c2c3ca9061142","after":"4feca1b19500586995942b1c626139ae003d7ed8","ref":"refs/heads/eks-boot","pushedAt":"2024-07-31T08:56:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"revert integ test","shortMessageHtmlLink":"revert integ test"}},{"before":"82f1b5af123a1cebd72faa4c5af79199dbd8348a","after":"b275cc14fc48d08f3a846a7cdb5c2c3ca9061142","ref":"refs/heads/eks-boot","pushedAt":"2024-07-31T05:50:34.000Z","pushType":"push","commitsCount":17,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"Merge branch 'main' into eks-boot","shortMessageHtmlLink":"Merge branch 'main' into eks-boot"}},{"before":"62d09ae7c1bf992942dcef5fc8d059fd05141c80","after":"b4f36b293052bd28700b1162ae438682f61f1442","ref":"refs/heads/ecs-mem","pushedAt":"2024-07-30T18:27:31.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"mergify[bot]","name":null,"path":"/apps/mergify","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/10562?s=80&v=4"},"commit":{"message":"Merge branch 'main' into ecs-mem","shortMessageHtmlLink":"Merge branch 'main' into ecs-mem"}},{"before":"78f66a0c7640e6fef468c80d7ecee5ff849e3e5d","after":"62d09ae7c1bf992942dcef5fc8d059fd05141c80","ref":"refs/heads/ecs-mem","pushedAt":"2024-07-30T17:48:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"revert windows outside of fargate checks","shortMessageHtmlLink":"revert windows outside of fargate checks"}},{"before":"e0978bd2786e57dfbe0f4bbe73d41b9a38b7e696","after":"78f66a0c7640e6fef468c80d7ecee5ff849e3e5d","ref":"refs/heads/ecs-mem","pushedAt":"2024-07-29T05:53:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"support lazy values","shortMessageHtmlLink":"support lazy values"}},{"before":"8ef2fb1d7ada13df674a66c08fa40b6a10d885d2","after":"e0978bd2786e57dfbe0f4bbe73d41b9a38b7e696","ref":"refs/heads/ecs-mem","pushedAt":"2024-07-29T05:11:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"spelling+add integ tests","shortMessageHtmlLink":"spelling+add integ tests"}},{"before":"928efc27a7efc87a7ad98a5584c836c2a8567fac","after":"8ef2fb1d7ada13df674a66c08fa40b6a10d885d2","ref":"refs/heads/ecs-mem","pushedAt":"2024-07-29T04:36:43.000Z","pushType":"push","commitsCount":163,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"Merge branch 'main' into ecs-mem","shortMessageHtmlLink":"Merge branch 'main' into ecs-mem"}},{"before":"1785c0f39afde8de941ad6c8f6fe09c18def2866","after":"82f1b5af123a1cebd72faa4c5af79199dbd8348a","ref":"refs/heads/eks-boot","pushedAt":"2024-07-25T11:23:37.000Z","pushType":"push","commitsCount":40,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"resolve merge conflict","shortMessageHtmlLink":"resolve merge conflict"}},{"before":"597228c1552a21f8dc7250a0be62160f838bb776","after":"84dd06b07d112db43119be3cbffe66b898092b33","ref":"refs/heads/main","pushedAt":"2024-07-25T11:18:21.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"chore(bedrock): support meta llama3-1 (#30932)\n\nAdd Meta Llama 3.1 model.\n\nRef\n* https://aws.amazon.com/about-aws/whats-new/2024/07/meta-llama-3-1-generative-ai-models-amazon-bedrock/\n* https://docs.aws.amazon.com/bedrock/latest/userguide/model-ids.html\n\n### Checklist\n- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"chore(bedrock): support meta llama3-1 (aws#30932)"}},{"before":"645baf78251ae10bcd3b18a25fc030e67d977a90","after":"fae5718dd3c281dd4805230c9b61765b33f7a047","ref":"refs/heads/s3-deploy","pushedAt":"2024-07-25T11:05:00.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"Merge branch 'main' into s3-deploy","shortMessageHtmlLink":"Merge branch 'main' into s3-deploy"}},{"before":"497fd70760e5cedb7ef55b4551282bef2b1b0f1e","after":"645baf78251ae10bcd3b18a25fc030e67d977a90","ref":"refs/heads/s3-deploy","pushedAt":"2024-07-25T10:04:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"fix integ tests","shortMessageHtmlLink":"fix integ tests"}},{"before":"acc3ca90bba1ba511f48a3c32230f14b60c82aaf","after":"497fd70760e5cedb7ef55b4551282bef2b1b0f1e","ref":"refs/heads/s3-deploy","pushedAt":"2024-07-24T23:40:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"fix integ tests","shortMessageHtmlLink":"fix integ tests"}},{"before":"41dee1c2b70041f0e99c2d7c6e1bc8808d0ba09d","after":"acc3ca90bba1ba511f48a3c32230f14b60c82aaf","ref":"refs/heads/s3-deploy","pushedAt":"2024-07-24T23:00:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"unit tests","shortMessageHtmlLink":"unit tests"}},{"before":"aa5296576d70a40d1d3a8775840c3966672d4e0a","after":"41dee1c2b70041f0e99c2d7c6e1bc8808d0ba09d","ref":"refs/heads/s3-deploy","pushedAt":"2024-07-24T22:43:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"integ test","shortMessageHtmlLink":"integ test"}},{"before":null,"after":"aa5296576d70a40d1d3a8775840c3966672d4e0a","ref":"refs/heads/s3-deploy","pushedAt":"2024-07-24T22:00:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"add prop outputObjectKeys","shortMessageHtmlLink":"add prop outputObjectKeys"}},{"before":"3524718431ba4395c7f145300b4d0a0065ff5936","after":"597228c1552a21f8dc7250a0be62160f838bb776","ref":"refs/heads/main","pushedAt":"2024-07-24T09:52:59.000Z","pushType":"push","commitsCount":32,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"feat(ec2): add `versionDescription` property for `LaunchTemplate` (#30837)\n\n### Issue # (if applicable)\n\n### Reason for this change\nThe change introduces the `versionDescription` property to the `LaunchTemplate`\n\n### Description of changes\n- Add the `versionDescription` property for `LaunchTemplateProps`, which was missing in the L2 construct.\n- Add validation for character limit \n\n### Description of how you validated changes\nI Added a unit test for launch template and added the `versionDescription` property in the integration tests.\n\n### Checklist\n- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)\n\n----\n\n*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*","shortMessageHtmlLink":"feat(ec2): add versionDescription property for LaunchTemplate (aw…"}},{"before":"34735f88ab139c666af89861f4934d069d0cf1ef","after":"1785c0f39afde8de941ad6c8f6fe09c18def2866","ref":"refs/heads/eks-boot","pushedAt":"2024-07-15T12:12:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mrlikl","name":"Murali Krishnan","path":"/mrlikl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/110023377?s=80&v=4"},"commit":{"message":"dry run failing integ tests #30583","shortMessageHtmlLink":"dry run failing integ tests aws#30583"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xNlQwNDo1NDozNS4wMDAwMDBazwAAAAS3Clxt","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xNlQwNDo1NDozNS4wMDAwMDBazwAAAAS3Clxt","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNy0xNVQxMjoxMjo0NS4wMDAwMDBazwAAAAR_qNY_"}},"title":"Activity · mrlikl/aws-cdk"}