Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed several issues #4

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fixed several issues #4

wants to merge 7 commits into from

Conversation

Systm21
Copy link

@Systm21 Systm21 commented Sep 11, 2023

  • temporary fixed python version check
  • fixed output_folder issue
  • deleted obolete settings-template.toml
  • create keys folder
  • placed infofile for placing keys

Copy link
Owner

@mrmay-dev mrmay-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! The latest update also has most of these. I've thought of making the code Python 3.11+ exclusively to avoid the version check. I'd hate to shut anyone out if Python 3.7 can do the job.

What do you think?

@Systm21
Copy link
Author

Systm21 commented Sep 12, 2023

The Problem for me was, that Python 3.11 can't find the tomllib and gives me errors. But its an onboard library, right? So i disabled it temporary to find the other issues.

You can update it later (or implement a working version check,), if everything works fine.
I would not recommend to remove it completely.

@mrmay-dev
Copy link
Owner

Interesting. I wonder why.

Is there a better way to check the version?
Maybe a try: except: would work better?
Or, add a line in the settings.toml. But I'd like to keep that as simple as possible. It can already be confusing with the individual keyfile blocks.

@Systm21
Copy link
Author

Systm21 commented Sep 12, 2023

I dont have much experience with python, sorry.

According to the keyfile blocks, the readme should get a polish after everything works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants