You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I create new symlink inside dir or symlink, it will be ignored as expected, but when I put path to symlink as an argument to fast-globfollowSymbolicLinks is ignored
Here we have a base directory (issue-300) from which we start reading deeper. When we encounter a symlink (./issue-300/symlink) we ignore it due to the followSymbolicLinks option.
In the other case, when two patterns (./issue-300/directory/** and ./issue-300/symlink/**) are specified we have two different base directories (./issue-300/directory, ./issue-300/symlink) from which the reading starts in depth. We do not check that the base directory is a symlink or not, because we consider it a cwd.
To me, it looks like right now we should fix the documentation based on the follow option description from node-glob.
Follow symlinked directories when expanding ** patterns. Note that this can result in a lot of duplicate references in the presence of cyclic links. https://github.com/isaacs/node-glob#options
Then I looked at the behavior of ripgrep and it seems that the last call displays what you want.
The current architecture makes it difficult to implement this behavior. We must stop using the base directory as cwd in favor of handling it through all our filters. Looks like this query requires an implementation of the feature request from #47.
Right now, I'll fix the documentation and mark this issue as feature request. Unfortunately now you have to consider adding filtering on your side.
mrmlnc
changed the title
bug with followSymbolicLinks
Exclude the base directory when is a symlink and the followSymbolicLinks option is disabled
Jun 27, 2021
Environment
Actual behavior
My structure:
Running code sample I get:
If I create new symlink inside
dir
orsymlink
, it will be ignored as expected, but when I put path to symlink as an argument tofast-glob
followSymbolicLinks
is ignoredExpected behavior
Steps to reproduce
Code sample
The text was updated successfully, but these errors were encountered: